mbox

[GIT,PULL,nf] Second Round of IPVS Fixes for v3.18

Message ID 1415758920-32578-1-git-send-email-horms@verge.net.au
State Accepted
Delegated to: Pablo Neira
Headers show

Pull-request

https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git tags/ipvs-fixes2-for-v3.18

Message

Simon Horman Nov. 12, 2014, 2:21 a.m. UTC 
Hi Pablo,

please consider this fix for v3.18.

It fixes handling of skb->sk which may cause incorrect handling
of connections from a local process.

This problem was introduced in its current form by 8052ba292559f907e
("ipvs: support ipv4 in ipv6 and ipv6 in ipv4 tunnel forwarding") in
v3.18-rc1.

I believe it also exists in a different form in older kernels.
No fix for that is available at this time.


The following changes since commit 2196937e12b1b4ba139806d132647e1651d655df:

  netfilter: ipset: small potential read beyond the end of buffer (2014-11-11 13:46:37 +0100)

are available in the git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git tags/ipvs-fixes2-for-v3.18

for you to fetch changes up to 50656d9df63d69ce399c8be62d4473b039dac36a:

  ipvs: Keep skb->sk when allocating headroom on tunnel xmit (2014-11-12 11:03:04 +0900)

----------------------------------------------------------------
Calvin Owens (1):
      ipvs: Keep skb->sk when allocating headroom on tunnel xmit

 net/netfilter/ipvs/ip_vs_xmit.c | 2 ++
 1 file changed, 2 insertions(+)
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Pablo Neira Ayuso Nov. 13, 2014, 11:38 a.m. UTC | #1 
On Wed, Nov 12, 2014 at 11:21:59AM +0900, Simon Horman wrote:
> Hi Pablo,
> 
> please consider this fix for v3.18.
> 
> It fixes handling of skb->sk which may cause incorrect handling
> of connections from a local process.
> 
> This problem was introduced in its current form by 8052ba292559f907e
> ("ipvs: support ipv4 in ipv6 and ipv6 in ipv4 tunnel forwarding") in
> v3.18-rc1.

Pulled, thanks Simon.

> I believe it also exists in a different form in older kernels.
> No fix for that is available at this time.

AFAIK -stable also accepts backports if there's a clear relation
between this original patch in mainstream and the backported version.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman Nov. 14, 2014, 1:59 a.m. UTC | #2 
On Thu, Nov 13, 2014 at 12:38:18PM +0100, Pablo Neira Ayuso wrote:
> On Wed, Nov 12, 2014 at 11:21:59AM +0900, Simon Horman wrote:
> > Hi Pablo,
> > 
> > please consider this fix for v3.18.
> > 
> > It fixes handling of skb->sk which may cause incorrect handling
> > of connections from a local process.
> > 
> > This problem was introduced in its current form by 8052ba292559f907e
> > ("ipvs: support ipv4 in ipv6 and ipv6 in ipv4 tunnel forwarding") in
> > v3.18-rc1.
> 
> Pulled, thanks Simon.
> 
> > I believe it also exists in a different form in older kernels.
> > No fix for that is available at this time.
> 
> AFAIK -stable also accepts backports if there's a clear relation
> between this original patch in mainstream and the backported version.

Thanks. I will see about making one.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html