diff mbox

[1/2] netfilter: nft: select NFNETLINK

Message ID 1388311290-18366-2-git-send-email-eric@regit.org
State Accepted
Headers show

Commit Message

Eric Leblond Dec. 29, 2013, 10:01 a.m. UTC
In Kconfig, nft is set as depending on NFNETLINK so building nft as a
module or inside kernel is depending of the state of NFNETLINK inside
the kernel config. If someone wants to build nftables inside the
kernel, it is necessary to also build NFNETLINK inside the kernel.
But NFNETLINK can not be set in the menu so it is necessary to toggle
an external value such as logging or nfacct to have a switch of
NFNETLINK to kernel build.
This patch change the dependency to a select inside Kconfig to be able
to set the build of nftables as modules or inside kernel independently.

Signed-off-by: Eric Leblond <eric@regit.org>
---
 net/netfilter/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pablo Neira Ayuso Dec. 30, 2013, 5:18 p.m. UTC | #1
On Sun, Dec 29, 2013 at 11:01:29AM +0100, Eric Leblond wrote:
> In Kconfig, nft is set as depending on NFNETLINK so building nft as a
> module or inside kernel is depending of the state of NFNETLINK inside
> the kernel config. If someone wants to build nftables inside the
> kernel, it is necessary to also build NFNETLINK inside the kernel.
> But NFNETLINK can not be set in the menu so it is necessary to toggle
> an external value such as logging or nfacct to have a switch of
> NFNETLINK to kernel build.
> This patch change the dependency to a select inside Kconfig to be able
> to set the build of nftables as modules or inside kernel independently.

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index 4371c98..01f9f64 100644
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -414,7 +414,7 @@  config NETFILTER_SYNPROXY
 endif # NF_CONNTRACK
 
 config NF_TABLES
-	depends on NETFILTER_NETLINK
+	select NETFILTER_NETLINK
 	tristate "Netfilter nf_tables support"
 
 config NFT_EXTHDR