mbox series

[nft,0/9] tests: Move tests from files to shell.

Message ID cover.1507696149.git.rvarsha016@gmail.com
Headers show
Series tests: Move tests from files to shell. | expand

Message

Varsha Rao Oct. 11, 2017, 4:33 a.m. UTC 
Test files of tests/files/ are moved to tests/shell.

Varsha Rao (9):
  tests: files: Remove jump chain tests.
  tests: shell: Add test case for jump chain.
  tests: shell: Add test case for sets.
  tests: files: Remove tests for set.
  tests: shell: Add tests for variable definition.
  tests: files: Remove test cases for variable definition.
  tests: files: Remove tests for chain.
  tests: files: Remove tests for table.
  tests: files: Remove tests for verdict maps.

 tests/files/loop-detect.1                          |  8 -------
 tests/files/loop-detect.2                          |  7 ------
 tests/files/loop-detect.3                          |  7 ------
 tests/files/loop-detect.4                          |  7 ------
 tests/files/obj-chain                              | 22 -------------------
 tests/files/obj-table                              |  9 --------
 tests/files/set                                    | 14 ------------
 tests/files/symbolic-define.1                      |  7 ------
 tests/files/symbolic-define.2                      |  7 ------
 tests/files/symbolic-define.3                      |  6 ------
 tests/files/verdict-maps                           | 20 -----------------
 tests/shell/testcases/chains/0015check_jump_loop_1 | 11 ++++++++++
 tests/shell/testcases/nft-f/0013defines_1          | 25 ++++++++++++++++++++++
 tests/shell/testcases/nft-f/0014defines_1          | 25 ++++++++++++++++++++++
 tests/shell/testcases/nft-f/0015defines_1          | 24 +++++++++++++++++++++
 tests/shell/testcases/sets/0025anonymous_set_0     | 17 +++++++++++++++
 16 files changed, 102 insertions(+), 114 deletions(-)
 delete mode 100644 tests/files/loop-detect.1
 delete mode 100644 tests/files/loop-detect.2
 delete mode 100644 tests/files/loop-detect.3
 delete mode 100644 tests/files/loop-detect.4
 delete mode 100644 tests/files/obj-chain
 delete mode 100644 tests/files/obj-table
 delete mode 100644 tests/files/set
 delete mode 100644 tests/files/symbolic-define.1
 delete mode 100644 tests/files/symbolic-define.2
 delete mode 100644 tests/files/symbolic-define.3
 delete mode 100644 tests/files/verdict-maps
 create mode 100755 tests/shell/testcases/chains/0015check_jump_loop_1
 create mode 100755 tests/shell/testcases/nft-f/0013defines_1
 create mode 100755 tests/shell/testcases/nft-f/0014defines_1
 create mode 100755 tests/shell/testcases/nft-f/0015defines_1
 create mode 100755 tests/shell/testcases/sets/0025anonymous_set_0

Comments

Pablo Neira Ayuso Oct. 11, 2017, 9:57 a.m. UTC | #1 
Hi Varsha,

On Wed, Oct 11, 2017 at 10:03:56AM +0530, Varsha Rao wrote:
> Test files of tests/files/ are moved to tests/shell.

We have more than 100 tests these days, could you have a look at the
repository to see if this is adding redundant tests for what we have?
If we already have a test covering the same configuration, we should
just remove them from tests/files/.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Varsha Rao Oct. 14, 2017, 1:04 p.m. UTC | #2 
Hello Pablo,

On Wed, Oct 11, 2017 at 3:27 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> Hi Varsha,
>
> On Wed, Oct 11, 2017 at 10:03:56AM +0530, Varsha Rao wrote:
>> Test files of tests/files/ are moved to tests/shell.
>
> We have more than 100 tests these days, could you have a look at the
> repository to see if this is adding redundant tests for what we have?
> If we already have a test covering the same configuration, we should
> just remove them from tests/files/.
>
Sorry, the cover letter title and commit message looks misleading.
But I have removed the redundant ones and added tests which were
not there.

Thanks,
Varsha
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Pablo Neira Ayuso Oct. 17, 2017, 11:08 a.m. UTC | #3 
On Sat, Oct 14, 2017 at 06:34:28PM +0530, Varsha Rao wrote:
> Hello Pablo,
> 
> On Wed, Oct 11, 2017 at 3:27 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > Hi Varsha,
> >
> > On Wed, Oct 11, 2017 at 10:03:56AM +0530, Varsha Rao wrote:
> >> Test files of tests/files/ are moved to tests/shell.
> >
> > We have more than 100 tests these days, could you have a look at the
> > repository to see if this is adding redundant tests for what we have?
> > If we already have a test covering the same configuration, we should
> > just remove them from tests/files/.
> >
> Sorry, the cover letter title and commit message looks misleading.
> But I have removed the redundant ones and added tests which were
> not there.

Thanks for clarifying, I have applied this.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html