mbox series

[nf-next,0/3] NF NAT deduplication refactoring

Message ID 20230315214735.236444-1-jeremy@azazel.net
Headers show
Series NF NAT deduplication refactoring | expand

Message

Jeremy Sowden March 15, 2023, 9:47 p.m. UTC 
These three patches perform refactoring in NF NAT modules to remove
duplicate code.

Jeremy Sowden (3):
  netfilter: nf_nat_redirect: use `struct nf_nat_range2` in ipv4 API
  netfilter: nft_masq: deduplicate eval call-backs
  netfilter: nft_redir: deduplicate eval call-backs

 include/net/netfilter/nf_nat_redirect.h |  3 +-
 net/netfilter/nf_nat_redirect.c         | 58 ++++++++---------
 net/netfilter/nft_masq.c                | 75 +++++++++-------------
 net/netfilter/nft_redir.c               | 84 +++++++++----------------
 net/netfilter/xt_REDIRECT.c             | 10 ++-
 5 files changed, 96 insertions(+), 134 deletions(-)

Comments

Jeremy Sowden March 15, 2023, 9:49 p.m. UTC | #1 
On 2023-03-15, at 21:47:32 +0000, Jeremy Sowden wrote:
> These three patches perform refactoring in NF NAT modules to remove
> duplicate code.

Whoops!  Sent v1 out again by default.

J.

> Jeremy Sowden (3):
>   netfilter: nf_nat_redirect: use `struct nf_nat_range2` in ipv4 API
>   netfilter: nft_masq: deduplicate eval call-backs
>   netfilter: nft_redir: deduplicate eval call-backs
> 
>  include/net/netfilter/nf_nat_redirect.h |  3 +-
>  net/netfilter/nf_nat_redirect.c         | 58 ++++++++---------
>  net/netfilter/nft_masq.c                | 75 +++++++++-------------
>  net/netfilter/nft_redir.c               | 84 +++++++++----------------
>  net/netfilter/xt_REDIRECT.c             | 10 ++-
>  5 files changed, 96 insertions(+), 134 deletions(-)
> 
> -- 
> 2.39.2
> 
>
Jeremy Sowden March 15, 2023, 9:50 p.m. UTC | #2 
On 2023-03-15, at 21:49:25 +0000, Jeremy Sowden wrote:
> On 2023-03-15, at 21:47:32 +0000, Jeremy Sowden wrote:
> > These three patches perform refactoring in NF NAT modules to remove
> > duplicate code.
> 
> Whoops!  Sent v1 out again by default.

"by mistake", even.  Duh. :)

> J.
> 
> > Jeremy Sowden (3):
> >   netfilter: nf_nat_redirect: use `struct nf_nat_range2` in ipv4 API
> >   netfilter: nft_masq: deduplicate eval call-backs
> >   netfilter: nft_redir: deduplicate eval call-backs
> > 
> >  include/net/netfilter/nf_nat_redirect.h |  3 +-
> >  net/netfilter/nf_nat_redirect.c         | 58 ++++++++---------
> >  net/netfilter/nft_masq.c                | 75 +++++++++-------------
> >  net/netfilter/nft_redir.c               | 84 +++++++++----------------
> >  net/netfilter/xt_REDIRECT.c             | 10 ++-
> >  5 files changed, 96 insertions(+), 134 deletions(-)
> > 
> > -- 
> > 2.39.2
> > 
> >