mbox series

[conntrack-tools,0/8] Fixes for a recent Coverity tool run

Message ID 20220325105003.26621-1-phil@nwl.cc
Headers show
Series Fixes for a recent Coverity tool run | expand

Message

Phil Sutter March 25, 2022, 10:49 a.m. UTC 
Phil Sutter (8):
  hash: Flush tables when destroying
  cache: Fix features array allocation
  Fix potential buffer overrun in snprintf() calls
  helpers: ftp: Avoid ugly casts
  read_config_yy: Drop extra argument from dlog() call
  Don't call exit() from signal handler
  Drop pointless assignments
  connntrack: Fix for memleak when parsing -j arg

 src/cache.c          |  4 ++--
 src/conntrack.c      |  2 ++
 src/hash.c           |  1 +
 src/helpers/ftp.c    | 20 +++++++++-----------
 src/helpers/ssdp.c   |  1 -
 src/main.c           |  2 +-
 src/process.c        |  2 +-
 src/queue.c          |  4 ++--
 src/read_config_yy.y |  2 +-
 src/run.c            |  2 +-
 10 files changed, 20 insertions(+), 20 deletions(-)

Comments

Pablo Neira Ayuso March 28, 2022, 8:25 a.m. UTC | #1 
LGTM

On Fri, Mar 25, 2022 at 11:49:55AM +0100, Phil Sutter wrote:
> Phil Sutter (8):
>   hash: Flush tables when destroying
>   cache: Fix features array allocation
>   Fix potential buffer overrun in snprintf() calls
>   helpers: ftp: Avoid ugly casts
>   read_config_yy: Drop extra argument from dlog() call
>   Don't call exit() from signal handler
>   Drop pointless assignments
>   connntrack: Fix for memleak when parsing -j arg
> 
>  src/cache.c          |  4 ++--
>  src/conntrack.c      |  2 ++
>  src/hash.c           |  1 +
>  src/helpers/ftp.c    | 20 +++++++++-----------
>  src/helpers/ssdp.c   |  1 -
>  src/main.c           |  2 +-
>  src/process.c        |  2 +-
>  src/queue.c          |  4 ++--
>  src/read_config_yy.y |  2 +-
>  src/run.c            |  2 +-
>  10 files changed, 20 insertions(+), 20 deletions(-)
> 
> -- 
> 2.34.1
>