| Message ID | 20210202135544.3262383-1-leon@kernel.org |
|---|---|
| Headers | show |
| Series | Fix W=1 compilation warnings in net/* folder | expand |
On Tue, Feb 2, 2021 at 2:55 PM Leon Romanovsky <leon@kernel.org> wrote: > > From: Leon Romanovsky <leonro@nvidia.com> > > Hi, > > This short series fixes W=1 compilation warnings which I experienced > when tried to compile net/* folder. > Ok, but we never had a strong requirement about W=1, so adding Fixes: tag is adding unnecessary burden to stable teams all around the world.
On Tue, Feb 02, 2021 at 03:34:37PM +0100, Eric Dumazet wrote: > On Tue, Feb 2, 2021 at 2:55 PM Leon Romanovsky <leon@kernel.org> wrote: > > > > From: Leon Romanovsky <leonro@nvidia.com> > > > > Hi, > > > > This short series fixes W=1 compilation warnings which I experienced > > when tried to compile net/* folder. > > > > Ok, but we never had a strong requirement about W=1, so adding Fixes: > tag is adding I added because Jakub has checker that looks for Fixes lines in "net" patches. > unnecessary burden to stable teams all around the world. It is automatic. Thanks
On Tue, Feb 2, 2021 at 3:57 PM Leon Romanovsky <leon@kernel.org> wrote: > > On Tue, Feb 02, 2021 at 03:34:37PM +0100, Eric Dumazet wrote: > > On Tue, Feb 2, 2021 at 2:55 PM Leon Romanovsky <leon@kernel.org> wrote: > > > > > > From: Leon Romanovsky <leonro@nvidia.com> > > > > > > Hi, > > > > > > This short series fixes W=1 compilation warnings which I experienced > > > when tried to compile net/* folder. > > > > > > > Ok, but we never had a strong requirement about W=1, so adding Fixes: > > tag is adding > > I added because Jakub has checker that looks for Fixes lines in "net" > patches. Send this to net-next As I stated, we never enforce W=1 compilation rule. I understand we might want that for _future_ kernels. > > > unnecessary burden to stable teams all around the world. > > It is automatic. I do receive a copy of all backports in my mailbox, whenever I am tagged. I can tell you there is a lot of pollution. > > Thanks
On Tue, Feb 02, 2021 at 03:59:38PM +0100, Eric Dumazet wrote: > On Tue, Feb 2, 2021 at 3:57 PM Leon Romanovsky <leon@kernel.org> wrote: > > > > On Tue, Feb 02, 2021 at 03:34:37PM +0100, Eric Dumazet wrote: > > > On Tue, Feb 2, 2021 at 2:55 PM Leon Romanovsky <leon@kernel.org> wrote: > > > > > > > > From: Leon Romanovsky <leonro@nvidia.com> > > > > > > > > Hi, > > > > > > > > This short series fixes W=1 compilation warnings which I experienced > > > > when tried to compile net/* folder. > > > > > > > > > > Ok, but we never had a strong requirement about W=1, so adding Fixes: > > > tag is adding > > > > I added because Jakub has checker that looks for Fixes lines in "net" > > patches. > > Send this to net-next No problem. > > As I stated, we never enforce W=1 compilation rule. > > I understand we might want that for _future_ kernels. > > > > > > unnecessary burden to stable teams all around the world. > > > > It is automatic. > > I do receive a copy of all backports in my mailbox, whenever I am tagged. > > I can tell you there is a lot of pollution. I'm receiving them either. > > > > > Thanks
From: Leon Romanovsky <leonro@nvidia.com> Hi, This short series fixes W=1 compilation warnings which I experienced when tried to compile net/* folder. Thanks Leon Romanovsky (4): ipv6: silence compilation warning for non-IPV6 builds ipv6: move udp declarations to net/udp.h net/core: move ipv6 gro function declarations to net/ipv6 netfilter: move handlers to net/ip_vs.h include/net/ip_vs.h | 11 +++++++++++ include/net/ipv6.h | 3 +++ include/net/udp.h | 3 +++ net/core/dev.c | 4 +--- net/ipv6/icmp.c | 6 ++++++ net/ipv6/ip6_input.c | 3 +-- net/netfilter/ipvs/ip_vs_core.c | 12 ------------ 7 files changed, 25 insertions(+), 17 deletions(-) -- 2.29.2