mbox series

[nft,0/3] json: resolve multiple test case failures

Message ID 20201103182040.24858-1-fw@strlen.de
Headers show
Series json: resolve multiple test case failures | expand

Message

Florian Westphal Nov. 3, 2020, 6:20 p.m. UTC 
Over the last few months nft gained a few new features and test cases
that either do not have a json test case or fail in json mode.

First two patches only touch the test cases themselves, but the snat.t
failure turned out to be due to lack of feature parity with the normal
bison parser.

Thus that patch adds needed export/import facility for nat_type
and the netmap flag.

 src/json.c                     |   43 +++++++++++++---
 src/parser_json.c              |   70 +++++++++++++++++++++++++-
 tests/py/bridge/reject.t       |    2 
 tests/py/bridge/reject.t.json  |   72 +++++++++++++++++++++++++++
 tests/py/inet/dnat.t           |    4 -
 tests/py/inet/dnat.t.json      |   55 ++++++++++++++++++++
 tests/py/inet/sets.t.json      |   74 ++++++++++++++++++++++++++++
 tests/py/ip/icmp.t.json        |    4 -
 tests/py/ip/icmp.t.json.output |    2 
 tests/py/ip/snat.t.json        |  108 +++++++++++++++++++++++++++++++++++++++++
 10 files changed, 418 insertions(+), 16 deletions(-)

Comments

Pablo Neira Ayuso Nov. 4, 2020, 1:03 p.m. UTC | #1 
On Tue, Nov 03, 2020 at 07:20:37PM +0100, Florian Westphal wrote:
> Over the last few months nft gained a few new features and test cases
> that either do not have a json test case or fail in json mode.
> 
> First two patches only touch the test cases themselves, but the snat.t
> failure turned out to be due to lack of feature parity with the normal
> bison parser.
> 
> Thus that patch adds needed export/import facility for nat_type
> and the netmap flag.

Patches LGTM, thanks.