From patchwork Thu Jan 23 14:30:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phil Sutter X-Patchwork-Id: 1228067 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netfilter-devel-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=nwl.cc Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 483Pnj2tkdz9sR1 for ; Fri, 24 Jan 2020 01:30:33 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728803AbgAWOad (ORCPT ); Thu, 23 Jan 2020 09:30:33 -0500 Received: from orbyte.nwl.cc ([151.80.46.58]:39868 "EHLO orbyte.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726231AbgAWOad (ORCPT ); Thu, 23 Jan 2020 09:30:33 -0500 Received: from localhost ([::1]:52956 helo=tatos) by orbyte.nwl.cc with esmtp (Exim 4.91) (envelope-from ) id 1iudV9-0000mM-Ei; Thu, 23 Jan 2020 15:30:31 +0100 From: Phil Sutter To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org, Florian Westphal Subject: [nft PATCH 0/4] Covscan-induced review of ei_insert() Date: Thu, 23 Jan 2020 15:30:45 +0100 Message-Id: <20200123143049.13888-1-phil@nwl.cc> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org False covscan report led to closer investigation ei_insert() which identified dead code and some opportunities for improvement due to the fact that the only caller sorts the new intervals prior to calling said function. Note that if we at some point want to support merging of new and old set elements, we will probably have to revert these patches since we can't be sure anymore that there aren't any items with bigger values in the set already. Phil Sutter (4): segtree: Drop needless insertion in ei_insert() segtree: Drop dead code in ei_insert() segtree: Simplify overlap case in ei_insert() segtree: Refactor ei_insert() src/segtree.c | 101 +++++++++++++------------------------------------- 1 file changed, 25 insertions(+), 76 deletions(-)