mbox series

[nft,0/3] Fix JSON API after recent other changes

Message ID 20181024103504.23615-1-phil@nwl.cc
Headers show
Series Fix JSON API after recent other changes | expand

Message

Phil Sutter Oct. 24, 2018, 10:35 a.m. UTC 
Recent changes to context structs broke compiling with JSON support
enabled, patch 3 fixes this. While doing so, I noticed that struct
eval_ctx's comment wasn't updated - fixed by patch 1.

Finally, I didn't like how osf ttl support was implemented in JSON.
Patch 2 resolves this.

Phil Sutter (3):
  include: Fix comment for struct eval_ctx
  json: Fix osf ttl support
  json: Fix for recent changes to context structs

 doc/libnftables-json.adoc | 24 ++++++++++++
 include/rule.h            |  2 +-
 src/json.c                | 82 +++++++++++++++++++++++----------------
 src/parser_json.c         | 24 ++++++++----
 tests/py/inet/osf.t.json  | 35 +++++++++++++++--
 5 files changed, 121 insertions(+), 46 deletions(-)

Comments

Pablo Neira Ayuso Oct. 24, 2018, 10:55 a.m. UTC | #1 
On Wed, Oct 24, 2018 at 12:35:01PM +0200, Phil Sutter wrote:
> Recent changes to context structs broke compiling with JSON support
> enabled, patch 3 fixes this. While doing so, I noticed that struct
> eval_ctx's comment wasn't updated - fixed by patch 1.

My fault, sorry about this.

> Finally, I didn't like how osf ttl support was implemented in JSON.
> Patch 2 resolves this.

Series applied, thanks Phil.