| Message ID | nycvar.YFH.7.76.1901022016380.14047@cbobk.fhfr.pm |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | David Miller |
| Headers | show |
| Series | ixgbe: remove magic constant in ixgbe_reset_hw_82599() | expand |
> -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On > Behalf Of Jiri Kosina > Sent: Wednesday, January 2, 2019 11:21 AM > To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com> > Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux- > kernel@vger.kernel.org > Subject: [Intel-wired-lan] [PATCH] ixgbe: remove magic constant in > ixgbe_reset_hw_82599() > > From: Jiri Kosina <jkosina@suse.cz> > > ixgbe_reset_hw_82599() resets the value of hw->mac.num_rar_entries to > pre-defined value of 128. Let's get rid of that hardcoded literal, and use > IXGBE_82599_RAR_ENTRIES instead, the same way the normal initialization > path does. > > Signed-off-by: Jiri Kosina <jkosina@suse.cz> > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c index 1e49716f52bc..109f8de5a1c2 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c @@ -1048,7 +1048,7 @@ static s32 ixgbe_reset_hw_82599(struct ixgbe_hw *hw) * clear the multicast table. Also reset num_rar_entries to 128, * since we modify this value when programming the SAN MAC address. */ - hw->mac.num_rar_entries = 128; + hw->mac.num_rar_entries = IXGBE_82599_RAR_ENTRIES; hw->mac.ops.init_rx_addrs(hw); /* Store the permanent SAN mac address */