| Message ID | j2p2d0a357f1004250955i59969a2cp9fd9eb9f3ef22d4b@mail.gmail.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On 25.04.2010 18:55, Sedat Dilek wrote: > Rebuild ipv6 kernel-modules by: > > $ make M=net/ipv6 > > ...and copied net/ipv6/*.ko and net/ipv6/netfilter/*.ko files manually > to the right place. > > Applied your patch (seen on netdev ML) already and booted into new kernel. > Works, thanks. > > Tested-by: Sedat Dilek<sedat.dilek@gmail.com> > > - Sedat - > > On Sun, Apr 25, 2010 at 6:39 PM, Eric Dumazet<eric.dumazet@gmail.com> wrote: >> Le dimanche 25 avril 2010 à 18:36 +0200, Piotr Hosowicz a écrit : >>> On 25.04.2010 18:31, Sedat Dilek wrote: >>>> [ CCing netdev ML ] >>>> >>>> Confirmed: The revert-patch [1] fixes the problem here. >>> >>> I confirm, I've built a git6 kernel and it works fine. >>> >>>> See also "Bug 15847 - crash in inet6_csk_bind_conflict" [2]. >>>> >>>> Feel free to add a... Tested-by: Sedat Dilek<sedat.dilek@gmail.com> >>> >>> I added created and tested phrase in my archive. ;-) Thank you a lot. I >>> hope there will be no this error in git7. >>> >> >> Did you test the proposed fix ? Eric, but where to get the proposed fix as a patch? I looked at kernel's bugzilla and there is no such thing. As for now I applied Sedat's reverse patch and now I am booted fine in git6 kernel. Regards, Piotr Hosowicz >> [PATCH] ipv6: Fix inet6_csk_bind_conflict() >> >> Commit fda48a0d7a84 (tcp: bind() fix when many ports are bound) >> introduced a bug on IPV6 part. >> We should not call ipv6_addr_any(inet6_rcv_saddr(sk2)) but >> ipv6_addr_any(inet6_rcv_saddr(sk)) because sk2 can be IPV4, while sk is >> IPV6. >> >> Reported-by: Michael S. Tsirkin<mst@redhat.com> >> Signed-off-by: Eric Dumazet<eric.dumazet@gmail.com> >> --- >> diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c >> index b4b7d40..3a4d92b 100644 >> --- a/net/ipv6/inet6_connection_sock.c >> +++ b/net/ipv6/inet6_connection_sock.c >> @@ -48,7 +48,7 @@ int inet6_csk_bind_conflict(const struct sock *sk, >> ipv6_rcv_saddr_equal(sk, sk2)) >> break; >> else if (sk->sk_reuse&& sk2->sk_reuse&& >> - !ipv6_addr_any(inet6_rcv_saddr(sk2))&& >> + !ipv6_addr_any(inet6_rcv_saddr(sk))&& >> ipv6_rcv_saddr_equal(sk, sk2)) >> break; >> } >> >> >>
Le dimanche 25 avril 2010 à 19:01 +0200, Piotr Hosowicz a écrit : > On 25.04.2010 18:55, Sedat Dilek wrote: > > Rebuild ipv6 kernel-modules by: > > > > $ make M=net/ipv6 > > > > ...and copied net/ipv6/*.ko and net/ipv6/netfilter/*.ko files manually > > to the right place. > > > > Applied your patch (seen on netdev ML) already and booted into new kernel. > > Works, thanks. > > > > Tested-by: Sedat Dilek<sedat.dilek@gmail.com> > > > > - Sedat - > > > > On Sun, Apr 25, 2010 at 6:39 PM, Eric Dumazet<eric.dumazet@gmail.com> wrote: > >> Le dimanche 25 avril 2010 à 18:36 +0200, Piotr Hosowicz a écrit : > >>> On 25.04.2010 18:31, Sedat Dilek wrote: > >>>> [ CCing netdev ML ] > >>>> > >>>> Confirmed: The revert-patch [1] fixes the problem here. > >>> > >>> I confirm, I've built a git6 kernel and it works fine. > >>> > >>>> See also "Bug 15847 - crash in inet6_csk_bind_conflict" [2]. > >>>> > >>>> Feel free to add a... Tested-by: Sedat Dilek<sedat.dilek@gmail.com> > >>> > >>> I added created and tested phrase in my archive. ;-) Thank you a lot. I > >>> hope there will be no this error in git7. > >>> > >> > >> Did you test the proposed fix ? > > Eric, but where to get the proposed fix as a patch? I looked at kernel's > bugzilla and there is no such thing. As for now I applied Sedat's > reverse patch and now I am booted fine in git6 kernel. > I wont spend my Sunday time at filling bugzilla entries. I sent a patch on netdev. I finaly could test it (I have a very slow machine while traveling, and compiling the thing took a *lot* of time) Now back to family affairs ;) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Apr 25, 2010 at 7:01 PM, Piotr Hosowicz <piotr@hosowicz.com> wrote: > On 25.04.2010 18:55, Sedat Dilek wrote: >> [...] >> On Sun, Apr 25, 2010 at 6:39 PM, Eric Dumazet<eric.dumazet@gmail.com> >> wrote: >>> >>> Le dimanche 25 avril 2010 à 18:36 +0200, Piotr Hosowicz a écrit : >>>> >>>> On 25.04.2010 18:31, Sedat Dilek wrote: >>>>> >>>>> [ CCing netdev ML ] >>>>> >>>>> Confirmed: The revert-patch [1] fixes the problem here. >>>> >>>> I confirm, I've built a git6 kernel and it works fine. >>>> >>>>> See also "Bug 15847 - crash in inet6_csk_bind_conflict" [2]. >>>>> >>>>> Feel free to add a... Tested-by: Sedat Dilek<sedat.dilek@gmail.com> >>>> >>>> I added created and tested phrase in my archive. ;-) Thank you a lot. I >>>> hope there will be no this error in git7. >>>> >>> >>> Did you test the proposed fix ? > > Eric, but where to get the proposed fix as a patch? I looked at kernel's > bugzilla and there is no such thing. As for now I applied Sedat's reverse > patch and now I am booted fine in git6 kernel. > > Regards, > > Piotr Hosowicz > For easy catching proposed patched to LKML look at <patchwork.kernel.org> [1]. There you find other mailing-lists and further patches. Cut-N-Paste excerpts of Eric's email should also work :-). - Sedat - [1] https://patchwork.kernel.org/project/LKML/list/ [2] https://patchwork.kernel.org/patch/94961/ -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] ipv6: Fix inet6_csk_bind_conflict() Commit fda48a0d7a84 (tcp: bind() fix when many ports are bound) introduced a bug on IPV6 part. We should not call ipv6_addr_any(inet6_rcv_saddr(sk2)) but ipv6_addr_any(inet6_rcv_saddr(sk)) because sk2 can be IPV4, while sk is IPV6. Reported-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> --- diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c index b4b7d40..3a4d92b 100644 --- a/net/ipv6/inet6_connection_sock.c +++ b/net/ipv6/inet6_connection_sock.c @@ -48,7 +48,7 @@ int inet6_csk_bind_conflict(const struct sock *sk, ipv6_rcv_saddr_equal(sk, sk2)) break; else if (sk->sk_reuse && sk2->sk_reuse && - !ipv6_addr_any(inet6_rcv_saddr(sk2)) && + !ipv6_addr_any(inet6_rcv_saddr(sk)) && ipv6_rcv_saddr_equal(sk, sk2)) break; }