From patchwork Fri Oct 21 13:39:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Nelson X-Patchwork-Id: 685120 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3t0my82rYKz9ryT for ; Sat, 22 Oct 2016 00:40:00 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="key not found in DNS" (0-bit key; secure) header.d=nelint.com header.i=@nelint.com header.b=T4gIx20H; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934052AbcJUNjw (ORCPT ); Fri, 21 Oct 2016 09:39:52 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:33587 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933183AbcJUNji (ORCPT ); Fri, 21 Oct 2016 09:39:38 -0400 Received: by mail-pf0-f174.google.com with SMTP id 128so57533779pfz.0 for ; Fri, 21 Oct 2016 06:39:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nelint.com; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=VlsKPIdMzd3yTp+Ka2lyZoK4TvMN58uX2/uu4neGsd8=; b=T4gIx20H3OzT72Ok6sdIEtAzBZB38jsO6iQ9Z1765U3de56ACxTKXifLhicbXRIuO6 vm6MkNbOsJHU/4pxjvSBv8Fm3Wm+dQZfy45QzCLMpiZC6DSR9pG0ErwrmZNmwYtHEbDJ 3QXhgbpHbiwdlJqekY33qB+BHRwxyGda25Jeg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=VlsKPIdMzd3yTp+Ka2lyZoK4TvMN58uX2/uu4neGsd8=; b=XCxDMwzhdLpwHulVefyEf/GOOuEhwku5u7boy2Q2XdVk7kcbqmTclzk0jyAvFh9boT uWli/GdhcJcySaZWYtSWuc9bY+CDud17h/vWviV75YjofQ5n4ryFe97+ISxNnfvbiWTu /07GvHdkpF/iNU9dtk4Knb5blE0+D61DDquIjPhVdp0M0Pr+3xFo6Zmmqx4oC16rDLKq +2xAc8MPyHZmqViiYVwF6ErH0f8xt6MiG8CYyqk+00Xw7isuy3Mcbg4ebu4NukHF3jJW gy0/aYA1EZvS70hMC1Be56myDhMEWcxWGhD99BYYb37iqEQ9xVRtLma6x1xyS2ONm4fi hBKw== X-Gm-Message-State: ABUngveNlsVBzs76XBukPPB6VtPRHIqMz575/ovgx/Nc2XewbHPtHJ5k0HQU0NA4O0d7hw== X-Received: by 10.99.36.65 with SMTP id k62mr1452231pgk.88.1477057178030; Fri, 21 Oct 2016 06:39:38 -0700 (PDT) Received: from ?IPv6:2600:8800:1701:5800:8c1a:a8c5:1955:2657? ([2600:8800:1701:5800:8c1a:a8c5:1955:2657]) by smtp.gmail.com with ESMTPSA id xo5sm5486800pab.13.2016.10.21.06.39.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Oct 2016 06:39:37 -0700 (PDT) Subject: Re: commit-3ac72b7b63d5 breaks networking on iMX28 To: Henri Roosen , fugang.duan@nxp.com, "netdev@vger.kernel.org" References: From: Eric Nelson Message-ID: Date: Fri, 21 Oct 2016 06:39:35 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Henri, On 10/21/2016 02:19 AM, Henri Roosen wrote: > Hi, > > Unfortunately commit-3ac72b7b63d5 "net: fec: align IP header in > hardware" breaks networking on an iMX28 system. > > The commit seems valid for iMX6, where it is tested okay and solves the > unaligned accesses. > > On iMX28 I still see unaligned accesses and networking is broken. Can > anyone confirm this? > Reading the i.MX28 reference manual, it appears that this SoC doesn't have the RACC bit, and I missed removal of the FEC_QUIRK_HAS_RACC flag. Can you try with this patch? Please advise, Eric diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 692ee24..db5eee9 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -96,7 +96,7 @@ static struct platform_device_id fec_devtype[] = { }, { .name = "imx28-fec", .driver_data = FEC_QUIRK_ENET_MAC | FEC_QUIRK_SWAP_FRAME | - FEC_QUIRK_SINGLE_MDIO | FEC_QUIRK_HAS_RACC, + FEC_QUIRK_SINGLE_MDIO, }, { .name = "imx6q-fec", .driver_data = FEC_QUIRK_ENET_MAC | FEC_QUIRK_HAS_GBIT |