diff mbox series

[net-next,v2,07/13] jme: use new helper tcp_v6_gso_csum_prep

Message ID f9f6897b-8dc8-2036-97d4-60e154b57356@gmail.com
State Accepted
Delegated to: David Miller
Headers show
Series net: core: add helper tcp_v6_gso_csum_prep | expand

Commit Message

Heiner Kallweit Feb. 18, 2020, 8:06 p.m. UTC 
Use new helper tcp_v6_gso_csum_prep in additional network drivers.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/ethernet/jme.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Guo-Fu Tseng Feb. 19, 2020, 3:53 a.m. UTC | #1 
On Tue, 18 Feb 2020 21:06:11 +0100, Heiner Kallweit wrote
> Use new helper tcp_v6_gso_csum_prep in additional network drivers.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>  drivers/net/ethernet/jme.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
> index 2e4975572..de3c7ce93 100644
> --- a/drivers/net/ethernet/jme.c
> +++ b/drivers/net/ethernet/jme.c
> @@ -2077,12 +2077,7 @@ jme_tx_tso(struct sk_buff *skb, __le16 *mss, u8 *flags)
>  								IPPROTO_TCP,
>  								0);
>  		} else {
> -			struct ipv6hdr *ip6h = ipv6_hdr(skb);
> -
> -			tcp_hdr(skb)->check = ~csum_ipv6_magic(&ip6h->saddr,
> -								&ip6h->daddr, 0,
> -								IPPROTO_TCP,
> -								0);
> +			tcp_v6_gso_csum_prep(skb);
>  		}
> 
>  		return 0;
> -- 
> 2.25.1
Kallweit:

Looks good to me. Thank you.

Guo-Fu Tseng
diff mbox series

Patch

diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c
index 2e4975572..de3c7ce93 100644
--- a/drivers/net/ethernet/jme.c
+++ b/drivers/net/ethernet/jme.c
@@ -2077,12 +2077,7 @@  jme_tx_tso(struct sk_buff *skb, __le16 *mss, u8 *flags)
 								IPPROTO_TCP,
 								0);
 		} else {
-			struct ipv6hdr *ip6h = ipv6_hdr(skb);
-
-			tcp_hdr(skb)->check = ~csum_ipv6_magic(&ip6h->saddr,
-								&ip6h->daddr, 0,
-								IPPROTO_TCP,
-								0);
+			tcp_v6_gso_csum_prep(skb);
 		}
 
 		return 0;