diff mbox

[v4,binutils] Add BPF support to binutils...

Message ID f7ttw541ohz.fsf@redhat.com
State Not Applicable, archived
Delegated to: David Miller
Headers show

Commit Message

Aaron Conole May 1, 2017, 5:22 p.m. UTC 
David Miller <davem@davemloft.net> writes:

> This is mainly a synchronization point, I still need to look
> more deeply into Alexei's -g issue.
>
> New in this version from v3:
>  - Remove tailcall from opcode table
>  - Rearrange relocations so that numbers match with LLVM ones
>  - Emit relocs properly so that dwarf2 debug info tests pass
>  - Handle negative load/store offsets properly, add tests
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---

Latest results from x86-64 and aarch64:

Both are little endian.  The only difference is for x86-64, I'm off of
commit 750eaa47f10f ("x86: Check plt_got before using .plt.got") and
for aarch64 I'm off of ee7e95efb981 ("merge_gnu_build_notes reloc
deletion").  I don't think that should matter.

I've also got a small incremental to fix some trailing whitespace, and
s/SPARC/BPF/ in one file, attached.
x86-64:
  Running /home/aconole/git/binutils-gdb/gas/testsuite/gas/bpf/bpf.exp ...
  FAIL: jump
  FAIL: call
  FAIL: imm64a
  Running /home/aconole/git/binutils-gdb/gas/testsuite/gas/cfi/cfi.exp ...

aarch64 (pine64 board):
  Running /root/aarch64/git/binutils-gdb/gas/testsuite/gas/bpf/bpf.exp ...
  Running /root/aarch64/git/binutils-gdb/gas/testsuite/gas/cfi/cfi.exp ...

Comments

David Miller May 1, 2017, 5:42 p.m. UTC | #1 
From: Aaron Conole <aconole@bytheb.org>
Date: Mon, 01 May 2017 13:22:00 -0400

> Latest results from x86-64 and aarch64:

I'll see if I can reproduce here...

> I've also got a small incremental to fix some trailing whitespace, and
> s/SPARC/BPF/ in one file, attached.

Applied, thanks!
David Miller May 1, 2017, 5:52 p.m. UTC | #2 
From: Aaron Conole <aconole@bytheb.org>
Date: Mon, 01 May 2017 13:22:00 -0400

> x86-64:
>   Running /home/aconole/git/binutils-gdb/gas/testsuite/gas/bpf/bpf.exp ...
>   FAIL: jump
>   FAIL: call
>   FAIL: imm64a
>   Running /home/aconole/git/binutils-gdb/gas/testsuite/gas/cfi/cfi.exp ...

I cannot reproduce this, can you show what it says in the:

	/home/aconole/git/binutils-gdb/gas/testsuite/gas.log

file near the "FAIL" cases?
Aaron Conole May 1, 2017, 6:39 p.m. UTC | #3 
David Miller <davem@davemloft.net> writes:

> From: Aaron Conole <aconole@bytheb.org>
> Date: Mon, 01 May 2017 13:22:00 -0400
>
>> x86-64:
>>   Running /home/aconole/git/binutils-gdb/gas/testsuite/gas/bpf/bpf.exp ...
>>   FAIL: jump
>>   FAIL: call
>>   FAIL: imm64a
>>   Running /home/aconole/git/binutils-gdb/gas/testsuite/gas/cfi/cfi.exp ...
>
> I cannot reproduce this, can you show what it says in the:
>
> 	/home/aconole/git/binutils-gdb/gas/testsuite/gas.log
>
> file near the "FAIL" cases?

Executing on host: sh -c {/home/aconole/git/binutils-gdb/gas/testsuite/../../binutils/objdump  -dr dump.o >dump.out 2>gas.stderr}  /dev/null  (timeout = 300)
spawn [open ...]
regexp_diff match failure
regexp "^ 108:	95 00 00 00 00 00 00 00 	exit$"
line   " 108:	95 00 00 00 00 00 00 00 	exit	"
FAIL: jump


Same style of error for call and imm64a.  After reverting and then
re-applying your patch, the FAILs all go away, so I must have broken
these files somehow.  Sorry for the false alarm.

-Aaron
David Miller May 1, 2017, 6:50 p.m. UTC | #4 
From: Aaron Conole <aconole@bytheb.org>
Date: Mon, 01 May 2017 14:39:39 -0400

> David Miller <davem@davemloft.net> writes:
> 
>> From: Aaron Conole <aconole@bytheb.org>
>> Date: Mon, 01 May 2017 13:22:00 -0400
>>
>>> x86-64:
>>>   Running /home/aconole/git/binutils-gdb/gas/testsuite/gas/bpf/bpf.exp ...
>>>   FAIL: jump
>>>   FAIL: call
>>>   FAIL: imm64a
>>>   Running /home/aconole/git/binutils-gdb/gas/testsuite/gas/cfi/cfi.exp ...
>>
>> I cannot reproduce this, can you show what it says in the:
>>
>> 	/home/aconole/git/binutils-gdb/gas/testsuite/gas.log
>>
>> file near the "FAIL" cases?
> 
> Executing on host: sh -c {/home/aconole/git/binutils-gdb/gas/testsuite/../../binutils/objdump  -dr dump.o >dump.out 2>gas.stderr}  /dev/null  (timeout = 300)
> spawn [open ...]
> regexp_diff match failure
> regexp "^ 108:	95 00 00 00 00 00 00 00 	exit$"
> line   " 108:	95 00 00 00 00 00 00 00 	exit	"
> FAIL: jump
> 
> 
> Same style of error for call and imm64a.  After reverting and then
> re-applying your patch, the FAILs all go away, so I must have broken
> these files somehow.  Sorry for the false alarm.

Great, thanks for checking.
diff mbox

Patch

diff --git a/bfd/elf64-bpf.c b/bfd/elf64-bpf.c
index a42f768..b04fdfb 100644
--- a/bfd/elf64-bpf.c
+++ b/bfd/elf64-bpf.c
@@ -39,7 +39,7 @@  _bfd_bpf_elf_reloc_type_lookup (bfd *abfd ATTRIBUTE_UNUSED,
     {
     case BFD_RELOC_NONE:
       return &_bfd_bpf_elf_howto_table[R_BPF_NONE];
-     
+
     case BFD_RELOC_BPF_WDISP16:
       return &_bfd_bpf_elf_howto_table[R_BPF_WDISP16];
 
diff --git a/gas/config/tc-bpf.c b/gas/config/tc-bpf.c
index 36393b7..d78f06f 100644
--- a/gas/config/tc-bpf.c
+++ b/gas/config/tc-bpf.c
@@ -1,4 +1,4 @@ 
-/* tc-bpf.c -- Assemble for the SPARC
+/* tc-bpf.c -- Assemble for BPF
    Copyright (C) 2017 Free Software Foundation, Inc.
    This file is part of GAS, the GNU Assembler.
 
@@ -153,7 +153,7 @@  output_insn (struct bpf_it *theinsn)
   valueT opc = theinsn->opcode;
   char *toP = frag_more (theinsn->imm64 ? 16 : 8);
   char code, regs;
-  
+
   code = opc >> (64 - 8);
   regs = opc >> (64 - (8 + 8));
 
@@ -317,7 +317,7 @@  md_assemble (char *str ATTRIBUTE_UNUSED)
 		      if (c != '0' || mask != 1)
 			goto error;
 		      mask = 10;
-		    }			  
+		    }
 		  the_insn.opcode |= (mask << 52);
 		  continue;
 		}
@@ -337,7 +337,7 @@  md_assemble (char *str ATTRIBUTE_UNUSED)
 		      if (c != '0' || mask != 1)
 			goto error;
 		      mask = 10;
-		    }			  
+		    }
 		  the_insn.opcode |= (mask << 48);
 		  continue;
 		}
diff --git a/gas/testsuite/gas/bpf/bpf.exp b/gas/testsuite/gas/bpf/bpf.exp
index 363fd2c..5a8d54c 100644
--- a/gas/testsuite/gas/bpf/bpf.exp
+++ b/gas/testsuite/gas/bpf/bpf.exp
@@ -4,15 +4,15 @@ 
 # it under the terms of the GNU General Public License as published by
 # the Free Software Foundation; either version 3 of the License, or
 # (at your option) any later version.
-# 
+#
 # This program is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
-# 
+#
 # You should have received a copy of the GNU General Public License
 # along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA.  
+# Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA.
 
 # BPF assembler testsuite
 
diff --git a/gdb/bpf-tdep.c b/gdb/bpf-tdep.c
index 6629f73..9cca3bc 100644
--- a/gdb/bpf-tdep.c
+++ b/gdb/bpf-tdep.c
@@ -192,7 +192,7 @@  bpf_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
 
   tdep = XNEW (struct gdbarch_tdep);
   gdbarch = gdbarch_alloc (&info, tdep);
-  
+
   tdep->xxx = 0;
 
   set_gdbarch_num_regs (gdbarch, BPF_NUM_REGS);
diff --git a/opcodes/bpf-dis.c b/opcodes/bpf-dis.c
index 39656bf..e15acc1 100644
--- a/opcodes/bpf-dis.c
+++ b/opcodes/bpf-dis.c
@@ -79,7 +79,7 @@  print_insn_bpf (bfd_vma memaddr, disassemble_info *info)
     {
       getword = bfd_getl32;
       gethalf = bfd_getl16;
-    }  
+    }
 
   code = buffer[0];
   dest = (buffer[1] & 0xf0) >> 4;
-- 
2.9.3