diff mbox series

connector: fix defined but not used warning

Message ID dc9ecebc-d4af-cb98-b6ce-9f8c98917724@infradead.org
State Accepted, archived
Delegated to: David Miller
Headers show
Series connector: fix defined but not used warning | expand

Commit Message

Randy Dunlap July 7, 2018, 3:27 p.m. UTC 
From: Randy Dunlap <rdunlap@infradead.org>

Fix a build warning in connector.c when CONFIG_PROC_FS is not enabled
by marking the unused function as __maybe_unused.

../drivers/connector/connector.c:242:12: warning: 'cn_proc_show' defined but not used [-Wunused-function]

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Evgeniy Polyakov <zbr@ioremap.net>
Cc: netdev@vger.kernel.org
---
 drivers/connector/connector.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

David Miller July 8, 2018, 2:01 a.m. UTC | #1 
From: Randy Dunlap <rdunlap@infradead.org>
Date: Sat, 7 Jul 2018 08:27:53 -0700

> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix a build warning in connector.c when CONFIG_PROC_FS is not enabled
> by marking the unused function as __maybe_unused.
> 
> ../drivers/connector/connector.c:242:12: warning: 'cn_proc_show' defined but not used [-Wunused-function]
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Applied.
diff mbox series

Patch

--- linux-next-20180706.orig/drivers/connector/connector.c
+++ linux-next-20180706/drivers/connector/connector.c
@@ -19,6 +19,7 @@ 
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  */
 
+#include <linux/compiler.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/list.h>
@@ -239,7 +240,7 @@  void cn_del_callback(struct cb_id *id)
 }
 EXPORT_SYMBOL_GPL(cn_del_callback);
 
-static int cn_proc_show(struct seq_file *m, void *v)
+static int __maybe_unused cn_proc_show(struct seq_file *m, void *v)
 {
 	struct cn_queue_dev *dev = cdev.cbdev;
 	struct cn_callback_entry *cbq;