From patchwork Thu Oct 19 15:23:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 828169 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=AQUANTIA1COM.onmicrosoft.com header.i=@AQUANTIA1COM.onmicrosoft.com header.b="A0AzF8bb"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3yHt641zWgz9t4c for ; Fri, 20 Oct 2017 02:25:16 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753739AbdJSPZO (ORCPT ); Thu, 19 Oct 2017 11:25:14 -0400 Received: from mail-sn1nam01on0061.outbound.protection.outlook.com ([104.47.32.61]:30197 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753698AbdJSPZG (ORCPT ); Thu, 19 Oct 2017 11:25:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8y/4Rcnd/pCmNWrupIkouP0vbYWw83MR9gOTpiZi3uM=; b=A0AzF8bb7qo0gU+V2k/17Q7Ht1vMOEHdwnny5ZLLCvKhE4HKBiOPRiTa7aH9uXR5KAHawKgv+YUg0p0N0Q6rWDCcsZ2U2x+q0BKOZjN2dZ5RTsj4E3NvGrpHaDhxFEr0oD/M3FA2Tz9UVe7l+S6Fz5Nv3EpXN0Hyjcyj8elnjLk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; Received: from ubuntubox.rdc.aquantia.com (83.149.43.106) by BY2PR0701MB1960.namprd07.prod.outlook.com (10.163.155.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Thu, 19 Oct 2017 15:25:02 +0000 From: Igor Russkikh To: "David S . Miller" Cc: netdev@vger.kernel.org, David Arcari , Pavel Belous , Nadezhda Krupnina , Simon Edelhaus , Igor Russkikh Subject: [PATCH net 7/7] net: aquantia: Bad udp rate on default interrupt coalescing Date: Thu, 19 Oct 2017 18:23:59 +0300 Message-Id: X-Mailer: git-send-email 2.7.4 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [83.149.43.106] X-ClientProxiedBy: HE1PR07CA0018.eurprd07.prod.outlook.com (10.160.74.156) To BY2PR0701MB1960.namprd07.prod.outlook.com (10.163.155.18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d418abbe-415a-47f1-75c0-08d5170592d2 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(2017082002075)(2017052603199)(201703131423075)(201702281549075); SRVR:BY2PR0701MB1960; X-Microsoft-Exchange-Diagnostics: 1; BY2PR0701MB1960; 3:RNPkghpfxuAzUyx6kFOwNDWaI7n3lsECeuvJHo8ZWBkhj2o/KwwDXRrYY77Ha9DoJMVUedypzrI1eNWr1qzPiWrXme/02hXTNUs0jhPwMQmsX5Lm0IIj//RzLuAVLdBCsAII9Zk29/DVFBNssKVDjNliSrJz5qtWvBz5Jic2wxgkFW8N/WxDfV5deujuKLODZ0HwcbkzlwBmDGn3pLxqlxWAlk914CkurEnQWUFyjLhc2p8mzmm6ni5P8b9sClvp; 25:b3AX/Ye364BDVzv+XJA5QkLRnIBAFuTTrJJItP12ycH+C4VvRXE5voCnHMAGmSSULSZiJQX0yQO1IxuroYGPB7kqYP9bGk2UO9aJKxuWiJkItVFY0/LlKVgTMfWtUBK2HAozfjoqb3qmY7YzUfq650g7GmZCKm9xdT56dwKJBrXfOiTFLP6cqs6bvR0EU/aG90NteeKX1q2sKcSvJw+mLRFafKzIY/kuSkGnFE8GVFZnICAH72XyJjNQ+AEM03ErZIt+hNatrAowEBBVdbuwtIVxKDmJQx6Lq6gW3VHMGymzdk36ix1g1cOl8Tz+X2i4uVnc0iUWpcKykP5tXTdROA==; 31:1JSL+bsuMXrZHJKpuLKAhWbvYx2xgnqSgtKv2/UduJbakluNT5bORI8vpPw9bXgCa+2IKNL3tK9shemNIDLst9lj7WaDIDNlgyPAy5JodKzTu5sGh8vPGzF3pkpiwTdk9P1w7NRWYrUdJOL6VmNBiFQbHSJ0KtN6Z7HHYNRG8Qx2hT3eOwvQs0EnRfBjuDE1l9vwUwhNSD256uFRH+7ajMP5MgdnbfiolDfotr/doZU= X-MS-TrafficTypeDiagnostic: BY2PR0701MB1960: X-Microsoft-Exchange-Diagnostics: 1; BY2PR0701MB1960; 20:tZTuoMVyy42s31AEX4eaCTnX3AAvOSTSY4caNysCbEONvVWZ8TT9Ep+Y0dABMXgzzAdw/QNt3CdItiiaewVTWhf0Nu3hpTAiahXAS4Lymei0md8QPbo5pG0Gm1p3OVDnG1IzvJmLoMcRFwCeKgwmfPf8XBmjx6GXq8rr/aTIUu8SFaPRpOXJ7RcDr0HrquWtqh+qNPOPXwbcnpiBxojC+71WJnSVl+oYaTC6rhpXl2hRBExIUhPVQlDIdHNoWVsx6ON+Rd2SYJd/WiO8xXYmWN82uTfOU8UVxjk54J13sEMZIaITmGBVL3C0feC0kl44RX8jVgTEn4u1vmcsX3sPqlaBGeBROp6e6pBwmJ/14Otcnkuq2zLj2RmJezvpHwR+HgbhvZ0RF6EjS1c2K1vU72fV04yOmprvhDBzqNHGA4uZpdDql2oq/7G3akvo/pgEZ93WBbepyDdZj3GHGfmTb4LKpFJf4iV5KyNpValuOui9GQAt0a7+f4SOf4sGYI+X; 4:8rl383/u9Fw8zC6s0HOdXOpF2Wo4HAjyw/HHVsa6V0vYM2d2nocVa9nVdCYO7ONs3U0ue8vFY9Q+Tb/GM+SSu6zLgOupW+uQcKACvRJniv5ZDOpw3JtWqmdTmnsMtpp5C62FV8LEc647hF9SFKN5RHWObeSB0ZWQOSSUphrQpeMJ0ihUNKBk5zLBCOc4fliGwDCjsg0XQ6wYFHOTpbqAtZ+zjZQ/jqe4q+cna1V+fYJUCQgWT80txsBhwe9P7Rfn X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(6041248)(2016111802025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123560025)(20161123564025)(6043046)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BY2PR0701MB1960; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BY2PR0701MB1960; X-Forefront-PRVS: 0465429B7F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(346002)(376002)(189002)(199003)(8936002)(81166006)(81156014)(8676002)(66066001)(72206003)(478600001)(5003940100001)(6916009)(97736004)(86362001)(25786009)(6666003)(68736007)(2906002)(50226002)(54906003)(316002)(16586007)(16526018)(2950100002)(7736002)(305945005)(118296001)(47776003)(53936002)(6486002)(6116002)(101416001)(105586002)(76176999)(107886003)(50986999)(3846002)(4326008)(50466002)(106356001)(33646002)(5660300001)(36756003)(48376002)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR0701MB1960; H:ubuntubox.rdc.aquantia.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; BY2PR0701MB1960; 23:MpRTTHCvcxSFlC4yzGcecue7Li1e3TVvDvBJPVy+ppRgPq46fJhl86EkAtylrDkzMX8d6NhQAXLlD1Ilh0xi1pMi+xnOT9lGGke23M3o2g9Schi9g2QuMjOvQBpLhRU0TNpbXvJUtSzMBjegj7nWc1lnN46xHYlGFxCdvBvXqo7LSTCfO+EsQiXtaNolGDnmnsnOzy2QGJ38+G4nHJLU35aIFDBxu7WwyoP64DKDdJM6EP7yDV+vjlDHX3FDPlWu5AIWDz6hfMTeZc/uf6Jt5G1xFA2yOuMuhZ2NwMAyyOa1h9YcI0vBP1LchcQavqlFAEe0XTHQuuylK0SWaedgN9UyH4O0Ud2O8894v5ZdDrLHN70HXMrAhHIy+8iX7aMWAoqG9GL+6cly5BOEJETs3CiVOilRZ3yOo1JQ8uOSARDJ4TeCZVcCUX7h+2thpF2NUfiTu2RaBZA7IfAHBMZM9Rbrwe1n/sb/kSkXqa7wUwBJsW4y+vBkC6xCp6LXO/edTxh4yZxtCq5V4oYUu0G1xARnjCugIx0XSkHFTUMHmAEwaGjfj+GRWEDnwXRUK95iwShS6AMTsU9WVpLrWxKNX7mqqB/rLAK5Os4uwjxrSZHy24QporMCc22s21MqYYwl5FiGxg8aGIoUTzO2Z5KlawD1Lg+hxLjNS4s4c9UXD9v20f2EVm0QNC5JhlKTbPIkmRd0h2rcZSLRvjCf9sqyXcocVZnsUN8mNhcplwldyEmk7jI4z6tyhgdDTqJsjVmJKnva7A0frkwRkx/zCYJ3gbK8gKL3vAPAaGSxShqIVZ+1+phKpTaA8tVfzM9uVEwiS1yBGHdlwoEcRZ/CAYBnLbdymm+NNf/dxSNYBw+n83mlZJcUb4+rzMEJE9hI/ycL/Zba1CLYs2orEem9bBoci/v6Xq2sxpLzJ6C+ky1F6bEgcdf0nHKAjHC7aX/OBtmRofAmQO5Uiyd+1WwNq7rCFYExXUaDiSHl1YNiFEKIJG/0SOQTPIP0uLDDgvvTO/zgjAGwMHVnq7aRz2Klj1AK+zUvpS8vsAaluH3J5P/kf4CMFU2hXNS2mr+JQhDeZNTARFs9XC8BI0j6QH3Y0JaEu8hJMLz+5Wk0AYrIFdeDyZw= X-Microsoft-Exchange-Diagnostics: 1; BY2PR0701MB1960; 6:gGRVFamg1Xo1t8A1xZV85PtokOfr6xYBAo2DlvUlfhabvHQbn/5dB/UtPL775sQdHtW242q0COf8TExHERHnYgnZy9P3lDb/afNlxdRzXpHdQwm+tRjY7E7PKOg3SBG2dYfEOt3hteVUPP0VJitphxsrzTVtSZpgD+ltj+IgSUHScykmM4j1LqO+ZcAjqpN6GA7Y1U6JTAKD2hFjxaTXtw8T2fAMqdPWPQMyNV99/pmgBWJV5bZblEPFI7bddk2OaGZ6fHOkjH+u9WI59OZvI/uuEczNwaZMdqiVD/imYItg9UBEpG//tUR6xrnAvJem2+TgMKlbGWM2vlKvA+VH5g==; 5:APMuQWfftYKZdXKCdLPO8i6rtxulNwvP5GI7fYTQ8HN6tjh7JCfuVX8G6OybljBkvtxJdaPE2LRSxOj5A3FxYcvG+EDYrdUG7sjnkdVrAoMnIzlIC96YiUi9UA5wJuF0UFBTZNmVV8dTR6MMxm3WqA==; 24:ZvByC/RFxi7u5cboTy+Ay3UVpwgymfGrGE8wdF0Uk7fpA7mrk586GLIx6a4oPyT6e3LjRCZEXJGBBUwNnE60QgTc+1F9Hyt3LcSYEiSFnMw=; 7:kKqwo2HTgin++nDNEOGPoPgWGrncuROC3HKh8lZWGYt0TbMT+i3tjDp3B4JLUl3qKekKDwwfASbQ6MbrQ3SVy1anwJNvSvPy++2u3A8+Fy6QO7Jtl2lOEY+xOqeqqthAYJ1HrhBunYC559m0OtpORTU/GiWBg+hy560mxP2C2nTSIi8xhi7BXwTB3mEA5YVpOEi6pMwu234SGLow0/bZThJEuvcE4lDV76AT0B9Cv5M= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2017 15:25:02.7552 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR0701MB1960 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Default Tx rates cause very long ISR delays on Tx. 0xff is 510us delay, giving only ~ 2000 interrupts per seconds for Tx rings cleanup. With these settings udp tx rate was never higher than ~800Mbps on a single stream. Changing min delay to 0xF makes it way better with ~6Gbps TCP stream performance is almost unaffected by this change, since LSO optimizations play important role. CPU load is affected insignificantly by this change. Signed-off-by: Pavel Belous Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c index 11f7e71..ec68c20 100644 --- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c +++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c @@ -821,12 +821,12 @@ static int hw_atl_b0_hw_interrupt_moderation_set(struct aq_hw_s *self) itr_rx |= rx_max_timer << 0x10U; } else { static unsigned int hw_atl_b0_timers_table_tx_[][2] = { - {0xffU, 0xffU}, /* 10Gbit */ - {0xffU, 0x1ffU}, /* 5Gbit */ - {0xffU, 0x1ffU}, /* 5Gbit 5GS */ - {0xffU, 0x1ffU}, /* 2.5Gbit */ - {0xffU, 0x1ffU}, /* 1Gbit */ - {0xffU, 0x1ffU}, /* 100Mbit */ + {0xfU, 0xffU}, /* 10Gbit */ + {0xfU, 0x1ffU}, /* 5Gbit */ + {0xfU, 0x1ffU}, /* 5Gbit 5GS */ + {0xfU, 0x1ffU}, /* 2.5Gbit */ + {0xfU, 0x1ffU}, /* 1Gbit */ + {0xfU, 0x1ffU}, /* 100Mbit */ }; static unsigned int hw_atl_b0_timers_table_rx_[][2] = {