From patchwork Sat Sep 10 09:02:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 668348 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3sWSlz4pJgz9ssP for ; Sat, 10 Sep 2016 19:03:27 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754208AbcIJJDI (ORCPT ); Sat, 10 Sep 2016 05:03:08 -0400 Received: from mout.web.de ([212.227.15.14]:53356 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751672AbcIJJDG (ORCPT ); Sat, 10 Sep 2016 05:03:06 -0400 Received: from [192.168.1.3] ([77.181.94.136]) by smtp.web.de (mrweb004) with ESMTPSA (Nemesis) id 0MHJEh-1bmHCg288p-00E5ul; Sat, 10 Sep 2016 11:02:45 +0200 Subject: [PATCH 3/4] ATM-ZeitNet: Replace one kzalloc() call by kcalloc() To: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, Chas Williams <3chas3@gmail.com> References: <0b5381e1-d725-0706-1cc0-188df6c201f2@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: Date: Sat, 10 Sep 2016 11:02:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <0b5381e1-d725-0706-1cc0-188df6c201f2@users.sourceforge.net> X-Provags-ID: V03:K0:wIindToVhshjESlqwbDLEOLSViyCCiHB59Vq8qdSGiNiR1z1QYA AtDi6drKMuNV26j0t4deN1ieKE5YKNpFdy7HgFYJ+U6JZhP7kAcZ68xg60n2KcZTDHnhgLw miYmy6hCnNs0BVNsJsaqa8Gnrl2LZ3UrgZSzSZZthbwn+X7ddNiOvOM3P50DILSoM6nbjxH oxs9Nz5+JMaE4UpT2Mcxg== X-UI-Out-Filterresults: notjunk:1; V01:K0:vB/ZywomkQo=:trQLJo1TI+jEd53ZC2LXya ZSxAsOl4G37fK218LdKXx+Y8KBqrYcPlr7Tpkq2hwPqTjLUSvrZG2QVDV6lDVHHOz+O7A8dRx e69euDOEfdhsvAtEIQcEs7hll5J2uWEJ1WzWFIEdRjuNCFVFOjVZTis3HyvaBonhnKx+2TzSr T8KTXiHCdo1WU2oDKNcUiXa04WxbrC94F/W3GeHEx44bUE5dRfxdT+gQ0RSpcCbkq3anijYLE RZHaJ2PiMNh+8D2JfKCfnclO+Yt4NM29t62AcZ/3kOAN2xSUTBaADyrjxZhEjhpnPSc3ixKkw XOC6O2yltMU9xrAHgs3bAsyhaRaRdWB//EduugeEGynJVwcLyddHZMSjag3RyRfYTPjOqfZmt UHdscBdKy5mEgIzcqUQ6ufxamZfsEUyUdZV42RG+L9HEyIAEhESkFTimjTMHYbIin67Ckv+bP 99rSewltc30bvtlkUcSYabPNWtUs4X0SIe9p7fWysNMRCXurtmMEnmafUwzMux6P+veyeGAmy N/1hpkiZkgpo5alfb+S8SlBqLavYIhNZ8UqYklNT5UpdgRqpmD+hnPHPCIamcc76Qa7z62hH6 vzOeOlOshQMLSkl3giNV45MS2We+LdMcFYIQ95yVzv7/dM8l+RBlV69DEO+2cRqM7Ygoq64ez unoBEevud7Q0i5bfD99/+x5UiDeufcFnQ+QqUBecZ0XDoAsajghZERnQ6J6NVkh+Y8Wk2JjCU 8jPUxIra6TDvTZ8qL8FBZx9PKArudCKOx5uV0IrDKTHmfnXzqiZzIoycARlFpFXQ+kg8bcFla /2PAHrr Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Markus Elfring Date: Sat, 10 Sep 2016 10:21:15 +0200 * The script "checkpatch.pl" can point information out like the following. WARNING: Prefer kcalloc over kzalloc with multiply Thus fix the affected source code place. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. * Delete the local variable "size" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- drivers/atm/zatm.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/atm/zatm.c b/drivers/atm/zatm.c index 218c6af..2cc9e2a 100644 --- a/drivers/atm/zatm.c +++ b/drivers/atm/zatm.c @@ -598,12 +598,13 @@ static void close_rx(struct atm_vcc *vcc) static int start_rx(struct atm_dev *dev) { struct zatm_dev *zatm_dev; - int size,i; + int i; DPRINTK("start_rx\n"); zatm_dev = ZATM_DEV(dev); - size = sizeof(struct atm_vcc *)*zatm_dev->chans; - zatm_dev->rx_map = kzalloc(size,GFP_KERNEL); + zatm_dev->rx_map = kcalloc(zatm_dev->chans, + sizeof(*zatm_dev->rx_map), + GFP_KERNEL); if (!zatm_dev->rx_map) return -ENOMEM; /* set VPI/VCI split (use all VCIs and give what's left to VPIs) */ zpokel(zatm_dev,(1 << dev->ci_range.vci_bits)-1,uPD98401_VRR);