diff mbox series

[net] net: phy: realtek: fix double page ops in generic Realtekdriver

Message ID c2c9f3c6-81c4-7c27-8989-10331bb69dc6@gmail.com
State Accepted
Delegated to: David Miller
Headers show
Series [net] net: phy: realtek: fix double page ops in generic Realtekdriver | expand

Commit Message

Heiner Kallweit May 11, 2019, 5:44 a.m. UTC
When adding missing callbacks I missed that one had them set already.
Interesting that the compiler didn't complain.

Fixes: daf3ddbe11a2 ("net: phy: realtek: add missing page operations")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/phy/realtek.c | 2 --
 1 file changed, 2 deletions(-)

Comments

David Miller May 11, 2019, 5:02 p.m. UTC | #1
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Sat, 11 May 2019 07:44:48 +0200

> When adding missing callbacks I missed that one had them set already.
> Interesting that the compiler didn't complain.
> 
> Fixes: daf3ddbe11a2 ("net: phy: realtek: add missing page operations")
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Applied.
diff mbox series

Patch

diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
index 29ce07312..4988ccea6 100644
--- a/drivers/net/phy/realtek.c
+++ b/drivers/net/phy/realtek.c
@@ -332,8 +332,6 @@  static struct phy_driver realtek_drvs[] = {
 		.resume		= genphy_resume,
 		.read_page	= rtl821x_read_page,
 		.write_page	= rtl821x_write_page,
-		.read_page	= rtl821x_read_page,
-		.write_page	= rtl821x_write_page,
 	}, {
 		PHY_ID_MATCH_EXACT(0x001cc961),
 		.name		= "RTL8366RB Gigabit Ethernet",