| Message ID | c2578691537da081e7a762946d9cafb428a490c2.1555078557.git.echaudro@redhat.com |
|---|---|
| State | Rejected |
| Delegated to: | BPF Maintainers |
| Headers | show |
| Series | [bpf-next] libbpf: Add xsk.h to be installed by install_headers | expand |
> On Apr 12, 2019, at 7:17 AM, Eelco Chaudron <echaudro@redhat.com> wrote: > > The user API file xsk.h was not installed by install_headers, this > change will fix this. > > Signed-off-by: Eelco Chaudron <echaudro@redhat.com> Cc: Magnus Karlsson <magnus.karlsson@intel.com> Fixes: 1cad07884239 ("libbpf: add support for using AF_XDP sockets") Acked-by: Song Liu <songliubraving@fb.com> > --- > tools/lib/bpf/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile > index 008344507700..9b0a0f53d640 100644 > --- a/tools/lib/bpf/Makefile > +++ b/tools/lib/bpf/Makefile > @@ -230,6 +230,7 @@ install_headers: > $(call do_install,bpf.h,$(prefix)/include/bpf,644); \ > $(call do_install,libbpf.h,$(prefix)/include/bpf,644); > $(call do_install,btf.h,$(prefix)/include/bpf,644); > + $(call do_install,xsk.h,$(prefix)/include/bpf,644); > > install_pkgconfig: $(PC_FILE) > $(call QUIET_INSTALL, $(PC_FILE)) \ > -- > 2.18.1 >
On 04/12, Song Liu wrote: > > > > On Apr 12, 2019, at 7:17 AM, Eelco Chaudron <echaudro@redhat.com> wrote: > > > > The user API file xsk.h was not installed by install_headers, this > > change will fix this. > > > > Signed-off-by: Eelco Chaudron <echaudro@redhat.com> > > Cc: Magnus Karlsson <magnus.karlsson@intel.com> > Fixes: 1cad07884239 ("libbpf: add support for using AF_XDP sockets") > Acked-by: Song Liu <songliubraving@fb.com> Isn't it already in? See commit 379e2014c95b7 ("libbpf: add xsk.h to install_headers target"). > > --- > > tools/lib/bpf/Makefile | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile > > index 008344507700..9b0a0f53d640 100644 > > --- a/tools/lib/bpf/Makefile > > +++ b/tools/lib/bpf/Makefile > > @@ -230,6 +230,7 @@ install_headers: > > $(call do_install,bpf.h,$(prefix)/include/bpf,644); \ > > $(call do_install,libbpf.h,$(prefix)/include/bpf,644); > > $(call do_install,btf.h,$(prefix)/include/bpf,644); > > + $(call do_install,xsk.h,$(prefix)/include/bpf,644); > > > > install_pkgconfig: $(PC_FILE) > > $(call QUIET_INSTALL, $(PC_FILE)) \ > > -- > > 2.18.1 > > >
> On Apr 12, 2019, at 9:31 AM, Stanislav Fomichev <sdf@fomichev.me> wrote: > > On 04/12, Song Liu wrote: >> >> >>> On Apr 12, 2019, at 7:17 AM, Eelco Chaudron <echaudro@redhat.com> wrote: >>> >>> The user API file xsk.h was not installed by install_headers, this >>> change will fix this. >>> >>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com> >> >> Cc: Magnus Karlsson <magnus.karlsson@intel.com> >> Fixes: 1cad07884239 ("libbpf: add support for using AF_XDP sockets") >> Acked-by: Song Liu <songliubraving@fb.com> > Isn't it already in? See commit 379e2014c95b7 ("libbpf: add xsk.h to > install_headers target"). Good catch! Thanks Stanislav! Song >>> --- >>> tools/lib/bpf/Makefile | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile >>> index 008344507700..9b0a0f53d640 100644 >>> --- a/tools/lib/bpf/Makefile >>> +++ b/tools/lib/bpf/Makefile >>> @@ -230,6 +230,7 @@ install_headers: >>> $(call do_install,bpf.h,$(prefix)/include/bpf,644); \ >>> $(call do_install,libbpf.h,$(prefix)/include/bpf,644); >>> $(call do_install,btf.h,$(prefix)/include/bpf,644); >>> + $(call do_install,xsk.h,$(prefix)/include/bpf,644); >>> >>> install_pkgconfig: $(PC_FILE) >>> $(call QUIET_INSTALL, $(PC_FILE)) \ >>> -- >>> 2.18.1 >>> >>
Sorry messed it up :( Did a pull in the wrong directory to verify the patch was not existing… //Eelco On 12 Apr 2019, at 18:31, Stanislav Fomichev wrote: > On 04/12, Song Liu wrote: >> >> >>> On Apr 12, 2019, at 7:17 AM, Eelco Chaudron <echaudro@redhat.com> >>> wrote: >>> >>> The user API file xsk.h was not installed by install_headers, this >>> change will fix this. >>> >>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com> >> >> Cc: Magnus Karlsson <magnus.karlsson@intel.com> >> Fixes: 1cad07884239 ("libbpf: add support for using AF_XDP sockets") >> Acked-by: Song Liu <songliubraving@fb.com> > Isn't it already in? See commit 379e2014c95b7 ("libbpf: add xsk.h to > install_headers target"). > >>> --- >>> tools/lib/bpf/Makefile | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile >>> index 008344507700..9b0a0f53d640 100644 >>> --- a/tools/lib/bpf/Makefile >>> +++ b/tools/lib/bpf/Makefile >>> @@ -230,6 +230,7 @@ install_headers: >>> $(call do_install,bpf.h,$(prefix)/include/bpf,644); \ >>> $(call do_install,libbpf.h,$(prefix)/include/bpf,644); >>> $(call do_install,btf.h,$(prefix)/include/bpf,644); >>> + $(call do_install,xsk.h,$(prefix)/include/bpf,644); >>> >>> install_pkgconfig: $(PC_FILE) >>> $(call QUIET_INSTALL, $(PC_FILE)) \ >>> -- >>> 2.18.1 >>> >>
diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile index 008344507700..9b0a0f53d640 100644 --- a/tools/lib/bpf/Makefile +++ b/tools/lib/bpf/Makefile @@ -230,6 +230,7 @@ install_headers: $(call do_install,bpf.h,$(prefix)/include/bpf,644); \ $(call do_install,libbpf.h,$(prefix)/include/bpf,644); $(call do_install,btf.h,$(prefix)/include/bpf,644); + $(call do_install,xsk.h,$(prefix)/include/bpf,644); install_pkgconfig: $(PC_FILE) $(call QUIET_INSTALL, $(PC_FILE)) \
The user API file xsk.h was not installed by install_headers, this change will fix this. Signed-off-by: Eelco Chaudron <echaudro@redhat.com> --- tools/lib/bpf/Makefile | 1 + 1 file changed, 1 insertion(+)