diff mbox series

isdn/capi: fix defined but not used warnings

Message ID be682fe0-9d82-51d6-d45c-c2ced59129c9@infradead.org
State Accepted, archived
Delegated to: David Miller
Headers show
Series isdn/capi: fix defined but not used warnings | expand

Commit Message

Randy Dunlap July 7, 2018, 3:31 p.m. UTC 
From: Randy Dunlap <rdunlap@infradead.org>

Fix build warnings in drivers/isdn/capi/ when CONFIG_PROC_FS is not
enabled by marking the unused functions as __maybe_unused.

../drivers/isdn/capi/capi.c:1324:12: warning: 'capi20_proc_show' defined but not used [-Wunused-function]
../drivers/isdn/capi/capi.c:1347:12: warning: 'capi20ncci_proc_show' defined but not used [-Wunused-function]
../drivers/isdn/capi/capidrv.c:2454:12: warning: 'capidrv_proc_show' defined but not used [-Wunused-function]

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Karsten Keil <isdn@linux-pingi.de>
Cc: isdn4linux@listserv.isdn4linux.de (subscribers-only)
Cc: netdev@vger.kernel.org
---
 drivers/isdn/capi/capi.c    |    5 +++--
 drivers/isdn/capi/capidrv.c |    3 ++-
 2 files changed, 5 insertions(+), 3 deletions(-)

Comments

David Miller July 8, 2018, 2:01 a.m. UTC | #1 
From: Randy Dunlap <rdunlap@infradead.org>
Date: Sat, 7 Jul 2018 08:31:15 -0700

> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build warnings in drivers/isdn/capi/ when CONFIG_PROC_FS is not
> enabled by marking the unused functions as __maybe_unused.
> 
> ../drivers/isdn/capi/capi.c:1324:12: warning: 'capi20_proc_show' defined but not used [-Wunused-function]
> ../drivers/isdn/capi/capi.c:1347:12: warning: 'capi20ncci_proc_show' defined but not used [-Wunused-function]
> ../drivers/isdn/capi/capidrv.c:2454:12: warning: 'capidrv_proc_show' defined but not used [-Wunused-function]
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Applied.
diff mbox series

Patch

--- linux-next-20180706.orig/drivers/isdn/capi/capi.c
+++ linux-next-20180706/drivers/isdn/capi/capi.c
@@ -9,6 +9,7 @@ 
  *
  */
 
+#include <linux/compiler.h>
 #include <linux/module.h>
 #include <linux/errno.h>
 #include <linux/kernel.h>
@@ -1321,7 +1322,7 @@  static inline void capinc_tty_exit(void)
  * /proc/capi/capi20:
  *  minor applid nrecvctlpkt nrecvdatapkt nsendctlpkt nsenddatapkt
  */
-static int capi20_proc_show(struct seq_file *m, void *v)
+static int __maybe_unused capi20_proc_show(struct seq_file *m, void *v)
 {
 	struct capidev *cdev;
 	struct list_head *l;
@@ -1344,7 +1345,7 @@  static int capi20_proc_show(struct seq_f
  * /proc/capi/capi20ncci:
  *  applid ncci
  */
-static int capi20ncci_proc_show(struct seq_file *m, void *v)
+static int __maybe_unused capi20ncci_proc_show(struct seq_file *m, void *v)
 {
 	struct capidev *cdev;
 	struct capincci *np;
--- linux-next-20180706.orig/drivers/isdn/capi/capidrv.c
+++ linux-next-20180706/drivers/isdn/capi/capidrv.c
@@ -9,6 +9,7 @@ 
  *
  */
 
+#include <linux/compiler.h>
 #include <linux/module.h>
 #include <linux/errno.h>
 #include <linux/kernel.h>
@@ -2451,7 +2452,7 @@  lower_callback(struct notifier_block *nb
  * /proc/capi/capidrv:
  * nrecvctlpkt nrecvdatapkt nsendctlpkt nsenddatapkt
  */
-static int capidrv_proc_show(struct seq_file *m, void *v)
+static int __maybe_unused capidrv_proc_show(struct seq_file *m, void *v)
 {
 	seq_printf(m, "%lu %lu %lu %lu\n",
 		   global.ap.nrecvctlpkt,