diff mbox series

net: fec: remove redundant ipg clock disable

Message ID b88a935c6e3f845b8eac78c32e2f15743014e418.1558533375.git.baruch@tkos.co.il
State Accepted
Delegated to: David Miller
Headers show
Series net: fec: remove redundant ipg clock disable | expand

Commit Message

Baruch Siach May 22, 2019, 1:56 p.m. UTC
Don't disable the ipg clock in the regulator error path. The clock is
disable unconditionally two lines below the failed_regulator label.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 drivers/net/ethernet/freescale/fec_main.c | 1 -
 1 file changed, 1 deletion(-)

Comments

David Miller May 23, 2019, 12:34 a.m. UTC | #1
From: Baruch Siach <baruch@tkos.co.il>
Date: Wed, 22 May 2019 16:56:15 +0300

> Don't disable the ipg clock in the regulator error path. The clock is
> disable unconditionally two lines below the failed_regulator label.
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Applied to net-next.
diff mbox series

Patch

diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index aa7d4e27c5d1..f63eb2b57c3e 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -3473,7 +3473,6 @@  fec_probe(struct platform_device *pdev)
 		if (ret) {
 			dev_err(&pdev->dev,
 				"Failed to enable phy regulator: %d\n", ret);
-			clk_disable_unprepare(fep->clk_ipg);
 			goto failed_regulator;
 		}
 	} else {