From patchwork Wed Feb 15 20:01:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Belous X-Patchwork-Id: 728356 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vNqwx0jcRz9ryj for ; Thu, 16 Feb 2017 07:03:45 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=AQUANTIA1COM.onmicrosoft.com header.i=@AQUANTIA1COM.onmicrosoft.com header.b="kqdAYQng"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751958AbdBOUDo (ORCPT ); Wed, 15 Feb 2017 15:03:44 -0500 Received: from mail-co1nam03on0063.outbound.protection.outlook.com ([104.47.40.63]:44304 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751875AbdBOUDk (ORCPT ); Wed, 15 Feb 2017 15:03:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=yCmBn5AWSnXS90kqtd5OsXXtE0rVGazRPEgtg/is5RA=; b=kqdAYQngCkKt9Jd7qGYL/faHN6gls6kf7Ra+XahKaEVSjpPniRvf/NcYE8P9jVaHXhmJhNW5OGoFQTUREA8w5Zfh7K2fGPdAYurLKpx6HxliIyqe2RUHYUIfE5LNgS2cpB42RUhsZ9mNOMsBxgt0HSsZeafTm//U/mGaL+RVwEU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavel.Belous@aquantia.com; Received: from atltest07.rdc.aquantia.com (83.149.43.106) by BY2PR07MB533.namprd07.prod.outlook.com (10.141.218.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.888.16; Wed, 15 Feb 2017 20:03:31 +0000 From: Pavel Belous To: "David S . Miller" Cc: netdev@vger.kernel.org, Simon Edelhaus , Alexey Andriyanov , Lino Sanfilippo , Pavel Belous Subject: [PATCH net-next 09/13] net: ethernet: aquantia: Call netdev_register after all initialized. Date: Wed, 15 Feb 2017 23:01:17 +0300 Message-Id: X-Mailer: git-send-email 2.7.4 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [83.149.43.106] X-ClientProxiedBy: AM4PR02CA0035.eurprd02.prod.outlook.com (10.165.239.173) To BY2PR07MB533.namprd07.prod.outlook.com (10.141.218.16) X-MS-Office365-Filtering-Correlation-Id: e8bacff9-f2d8-4499-710f-08d455ddb80d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BY2PR07MB533; X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB533; 3:tWpdg6m89uPsh5GsAlEHMXe0lHAlYi8qz/Us6Y2vrDMCZ3UJUB88ND155jy9LJNTWohvWD9AfnT3aludkTg+liYdHy1SqTKLckfD/fANyKoqJOQMhp+yqSc643DfOMmgYCThFLs9zA/WMmgn4bRwAYiu/F8bh5rEGqzjVhICoO/T4kWPmFpD4frjs+9HULww6nzFDw4IL1UjDrB0YKn5eAuASSDEtcIvu4Q+H387ox+ZuchwDBR/pIPm7zIITXs+emJHlDJ2OfaWkwLjDzBrAQ==; 25:10rbtmJzm8icjqNFSlNFZHTJ9ERGH+QvtGMTHiasxBCwN7va1CYSA+XEVIw/pYwR6Zi43S2H9jGdpnC5jazwv7buXBL2aFiHyNeNjy/pxaErlxE6OMmu+GHGV78oX1WCMgke57GIKEH70kmaG+Ii8ZvZxwBtytQtClTKxWQGLm0ZBFqxhmmUjobLzHIB0EPMQksap9q3Nfw7oubK6+5peZa7FSs1CH9a9BjExMdyp8exheAeNdseuEZN/qdWr95Lh1SDNhHPU0Tq54wnxFIS6DJ9usBhhgJNs7NENxhDcd0+kWhbaP517FwIc8vkt459aTyt7wiPWpdKFHzK8gTE3OyDaYEC5SS1ED3bigERSjEkCPd03YWmTbjQj6T4hSD/xwHTI5sfwzEEujEcjVwsWWGN+F5rAfPTmzVN1TPjy22zeIY9KjZizTLpHdOJW7P3b5TpKXUhiVGHEMPm7AjVZw== X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB533; 31:1D1mXXH058cbHHKB35PHIcuCUQHrnfFS5C8fuE+kOC2RFiYxLbKUdZPcF0dsMneeqefvxj671QVPZmc3qx4iL6WuTSK5uNdbSahix7o2vioE2mfPiWaXrCSTZpkWVFp84HMiyUR2XY/ZeXOYlfcSdaoFvXgoAdhn7SG0iIjoPd/vxx7FG0p/XG5A1CU7Zf7vbYv8BDdm103m/CYFshDQu3FpgrwZzkxuxYMoSAAjjkqfVNNq33ge/tbaXUrGjyih; 20:j69oInDAgwUnBjfG0cqrBYHMHCymfjZDmabk26nJ0fgllWCTV8ZmPrXkp3FAmwSemcyOZObFkJgyDMTsOm4fSnU39hCtLwpK2HAJlFCqmcJDbNO6XhfTn/3IABNJQEJcVqJaJmtAMBP382od2kp22iU0hBMMJRVaDmoLLpXQXzO4dBYODMxJ+58I0wGawiXGvZBTlrDvZ06J+epWPcvS+/p28/i4ANVsu9e4keggJnA+Xye7ELupMO+jvYotQmINR1QE779vqoA+HbuFBG7ZiaWQXE82HjkTkxEtjBME9DL9ZbsHYcyYlDOOK/44UYd2pdpBsKzITihylWjEnGByH6WiZ9ZaPZxibbBdhq04NWVG8a3TW4rb6jacYUfpVtOHNjYGL+7r+RSPZ+1FmlvPPNP1YF8Lo97Kan9iBQ/W0KsjL6H1YSHifDE3XBu+XOPf2kAgFlJDble3pX9uC8FrPc886DxZOyiWtOX/S4M4L5blJoPqUgcsmMhqBD2Wqrqn X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123560025)(20161123564025)(20161123558025)(20161123562025)(20161123555025)(6072148); SRVR:BY2PR07MB533; BCL:0; PCL:0; RULEID:; SRVR:BY2PR07MB533; X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB533; 4:u20GLddhpjkJyoffPitCU4ryE1e8d3gwyIqCdP4so1eYjFeFv1xn3FxhDAlKRkg++wHxW/S0mZLiBCFqIys+U5b/MbsC7zjmoyjE4WJqlV4eV9rlmunjU1o+XIqHRiXwnbmx1sL5KJjOGeTYDWHfuVWV+1iV3cWoX8s5f9AjC6ali3unSAuBBnSfLNIc3GfPIuj5Ovhq7KLJ/5sfn+QTlK3Oaem2qtCXGHmSqPhR2OTEf294O8ahHYUT5BvarzXQIYDGj+T6ldu89VoKJI/rjx4sev4mzLJ1WTYrsre1AT+wtmQnJSK96OMItEGXXz3u1oc+T/mv+842lortlfBDyg11bnD/hoaRQZM2D2vmsQyNfzsNtc0/kdrtNlSCD+fMWBr1YH/sY+ArIkgJbkLCY36XGw9swQFP/2Idf+fusvaT82Sg5cYRq30Ns6Q4HiXFXgVyY64mQjYVYAX7cpwn/7HAaHJ8rqt6YeS1gAseQbDzGztA0v90bs7PVgFNeyyu69738a/c8uEd4m7F2WSPAvvHpxmKvTtNkwl04U+vdYYUeDt3Nnz2D4Duw0NFfCAJWMKjBPStVXIIxNvO3zMW+m/gBDRPRUtZm529DTeEN6E= X-Forefront-PRVS: 021975AE46 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(189002)(199003)(50466002)(118296001)(7736002)(76176999)(101416001)(4326007)(6116002)(25786008)(6486002)(5660300001)(50986999)(54906002)(42186005)(389900002)(8676002)(92566002)(106356001)(105586002)(305945005)(48376002)(81166006)(8666007)(33646002)(68736007)(6666003)(53936002)(86362001)(97736004)(3846002)(66066001)(107886003)(47776003)(110136004)(2950100002)(38730400002)(36756003)(6916009)(5003940100001)(189998001)(81156014)(50226002)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR07MB533; H:atltest07.rdc.aquantia.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR07MB533; 23:TsD0Kv+DvhZknRw03pKFHzw7WvWgMZj7cKLIcurblM?= =?us-ascii?Q?Fb04YfMaeHzMfYLatJI3w23dh6YxZOtu9TdRfJW5HwjiL3ttJpRcLng9S1SW?= =?us-ascii?Q?nZYeO3pu47GzcAEJHV8yWNQP+O4axdTqDNUM8bkITeJZcvNm6FNoXHfTgqMu?= =?us-ascii?Q?0//HWdiVt2Iu9uk5h2rYi7ShLkeQoj3x9G7p3zt/NVrB8kb/tOGuuU8RXBAT?= =?us-ascii?Q?KN1XNPMyJwn8TZq19kgKMitcLg+tWf0zCFV6GlcMbf3gzz9OUM4MMNqe3qZB?= =?us-ascii?Q?K6v1vtSqHk7eaEowl/S8Fd9sJjXyA//XAV1XkAqsTDdkR989ahcg/MUw9CZZ?= =?us-ascii?Q?6N+JJoTH2QsScbJzNm18ALKBKhrYmEoYNVM7njABKMkMCf6vp7k4yhlHwBkN?= =?us-ascii?Q?PzZfkS7SsdVxLWtK9a70tBMWnFAHuVtBqbHDXRP4B8QQPqpskVPa3heEpLRO?= =?us-ascii?Q?4XbXlXUzZIyIi9CE4lbVrRGb2ZLRn66CHJbHtGYwUNWhu3GohR4T6xoNPEzo?= =?us-ascii?Q?B1iXEODs4lh986mOr6V4W9ZhL4+D2JFh/JCHffaBOxrc01vRgZYkenNM9cMf?= =?us-ascii?Q?s9W8G5iMDvdniZlHu4EkWCILrqpnwkT5uvNmKTH7pOHhfEub7B8L/RntmjZl?= =?us-ascii?Q?NevptOZlldGW2cieLMYvfq+MYa+cbH7XZ1nENIpPXUuynjFUhrRdUke3r+rc?= =?us-ascii?Q?xkyEJ+v2/S7sQHdOK82LbgJ0lnSmdXDdTsiw606yJOzACp33iT9XJGLpau7a?= =?us-ascii?Q?oxpv4jj8YkM7FAwDgq8Zkgutg9vcxbvGzEmzLp3lo25y0LDkoikg6Gs/WbEg?= =?us-ascii?Q?7neWZfDuNCxur+Z7cznd9iEYQDKDFVGehhD/138Dq4rHnSjsnGn8U0ftqwv+?= =?us-ascii?Q?tNj88/3r4p0VQzVtf+NP/CeuQBG0TJL+QficWdPs7g3qH2l6hSxliOBEFYmQ?= =?us-ascii?Q?cuhY0srutEkvC6MBgvgtbvzCpDid4ZuDnOF7QFtIvtm8695KaPVa8a5Vfe6O?= =?us-ascii?Q?ODgh/avHcqxnKi2RtlQ4elYRyTwV15zRJxW8G4Sw8Ql4drKbBj501++WPtcr?= =?us-ascii?Q?rMsfxXpfp0SrFdaKRTHCvCMZ97DuiHLIKcvA8yxeqppeA2SsBlrch6CrCoMa?= =?us-ascii?Q?m9G8akXq4DvJOCLo6abya/u5P7I9h+vEOqOgINyUw0b4xRQwhDIA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB533; 6:58KdL0irIxhKpmXnBIvJVtw+++W7JKEd/1kjeKEwmqpQFVnfkYBGwoGk10n5T/+yfeAe3hCcV0F4w6PbFOQULPgj1V8r0z0hXFpVD35QLKO6U9+sKOFV/YuFg2RrC/WDO2Uj+NjI1BwNOB//dk0lSoSjBH2E9BrT138SfGNqkJZxTUDw8yruxL4cNMgXOjL9kpJZ/hsiqAsz3RvTKyQRD2u7EJRxuioyU/DrWU1CAKBQHR0rRQRlsu1DYILCmV36lz4TM5vYw+x6RMnYuzcuVzLklDuZc7/QwMPOHIvZnTmyqWjXxnUtnW4vSjHmjm+Xkh8P0iT25z2pf/3Y3SfYSxBKesK6u3gkUG35hWvFtIHBi7HbxrRmnL2eazRRaqOpdTp/Lcot1xVvEhJhgUuljQ==; 5:OlqBbJ2jRpfCgfW7KZVreQ1Wr52rWxH0Kfm+yLmrT6uRbu7BigPms81YxkhluFErhFApI/zi7tJZptdGBPiFke4eQSfyyLPtB5EvbvANnoE5snOqQJ+E9NdDtFw6umhpNb93eDRTcjvpbQcgnaBfH2xwdaRL52vIcj/bLDaOYWI=; 24:lDIMukX3xgKbAt4HATI2wfl2O47+4HKyua8OfFUHWt57y795SBF/9bJjOvGdpGDEs/bkxuEyVNFPTnx4Zp0T9tNPRNnUXAY3zqM+L+dumz0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB533; 7:JbaeESXFZlTRPQN2Xeh14xiyRG6FpiVgqHxppU/VMRmYVgEtTQPZjd0dUFO3Xb5yEHlQ18dzxUYEZlkY/Vol1cNO1LHzu8SCKfV3BGt249lxN0PDlheKiffhYZPS4wrzeCjX9CFdwLU7K1SqALdmMSeoTOsvlXe3VejPofYb/uwFkDvQJ71n0zVjt4OzS28meyC1DUA+cr8UoTsOnj5E7mwiHD4/g64P93WO1TYGS4RcYJupDtOXti7Whv77HXGfircMciQBKiBb/JSI9BLVH9P/6fWlUP2hOGFn4C8mXvELW4hVztK3XT/4TtjGfsSpR1ru6DW/jBmENG3ujbXaHQ== X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2017 20:03:31.4635 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR07MB533 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Pavel Belous netdev_register should be called when everything is initialized. Signed-off-by: Pavel Belous Reviewed-by: Lino Sanfilippo --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c index e50fba2..daed4c1 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c @@ -260,16 +260,18 @@ int aq_nic_ndev_register(struct aq_nic_s *self) ether_addr_copy(self->ndev->dev_addr, mac_addr_permanent); } #endif - err = register_netdev(self->ndev); - if (err < 0) - goto err_exit; - self->is_ndev_registered = true; netif_carrier_off(self->ndev); for (i = AQ_CFG_VECS_MAX; i--;) aq_nic_ndev_queue_stop(self, i); + err = register_netdev(self->ndev); + if (err < 0) + goto err_exit; + + self->is_ndev_registered = true; + err_exit: return err; }