| Message ID | alpine.DEB.2.20.12.1605081823420.3193@trent.utfs.org |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Christian Kujau <lists@nerdbynature.de> Date: Sun, 8 May 2016 18:23:59 -0700 (PDT) > In Documentation/networking/ip-sysctl.txt, the accept_source_route > parameter is described with: > > Accept packets with SRR option. Every single variable name and function name dealing with this IP option uses "srr", therefore I don't think we should adjust the documentation either. "srr" covers both the loose source route option and the strict source route option. Thanks.
On Tue, 10 May 2016, David Miller wrote: > Every single variable name and function name dealing with this IP > option uses "srr", therefore I don't think we should adjust the > documentation either. > > "srr" covers both the loose source route option and the strict source > route option. Now that I know where the 2nd "r" comes from, the "srr" makes sense. So yeah, SRR it is. Maybe a hint to the correct RFC would help, but if nobody else complained yet, I guess it's not really worth the commit. Thanks, Christian.
diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt index b183e2b..db6b538 100644 --- a/Documentation/networking/ip-sysctl.txt +++ b/Documentation/networking/ip-sysctl.txt @@ -1057,9 +1057,9 @@ bootp_relay - BOOLEAN Not Implemented Yet. accept_source_route - BOOLEAN - Accept packets with SRR option. + Accept packets with SSRR option (RFC791 3.1). conf/all/accept_source_route must also be set to TRUE to accept packets - with SRR option on the interface + with SSRR option on the interface default TRUE (router) FALSE (host)
In Documentation/networking/ip-sysctl.txt, the accept_source_route parameter is described with: Accept packets with SRR option. I could not find anything describing an "SRR option". The closest thing was something called "SSR - Strict Source Route"[0] - is that what is meant here? If so, RFC791 then refers to the same as "SSRR", as in "strict source and record route". Does the patch below clears that up or did I confuse it with something else? Thanks, Christian. Signed-off-by: Christian Kujau <lists@nerdbynature.de> [0] https://www.iana.org/assignments/ip-parameters/ip-parameters.xhtml