From patchwork Fri May 23 15:46:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Herbert X-Patchwork-Id: 351918 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4F2531400A0 for ; Sat, 24 May 2014 01:47:03 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753414AbaEWPq6 (ORCPT ); Fri, 23 May 2014 11:46:58 -0400 Received: from mail-vc0-f201.google.com ([209.85.220.201]:60669 "EHLO mail-vc0-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753205AbaEWPq4 (ORCPT ); Fri, 23 May 2014 11:46:56 -0400 Received: by mail-vc0-f201.google.com with SMTP id ij19so882302vcb.2 for ; Fri, 23 May 2014 08:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:subject:message-id:user-agent:mime-version :content-type; bh=ckmgXBm4SyXxCNBGa10WMjSqjrP6S2tv46jAhOo6ZT4=; b=Fy6SK1TCYFLukaTpOhW/IZrk2eX8gCQTvbNGpD2VAPhM2xXB0K+LYSHYJSn77y+qOf W3HGq9h28xxHrZWlLhja85DhJjov6XBp5m+Gpy5DQydCN8SzjSr7zgimqQoau9yslQVF EwyFHOf7g9DvxYtm8VzPblo+V3Z+jUx4R+KzopgzsB8B8VErQIoS3CA+Ig4jin0WaDAL 2TNohJLMC3XrmN5Ynjw6DJwVYE5fWD5XEIIQQ0hlObU3zAT7uFwBUZDoilLzqjlu+gZD TWWNasiqN4TQsOViBLOpcNv0vjP89+JyxD4A45EcsyNmkuhLMYAEFcHHtx6K2QgxSW26 I+Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:user-agent :mime-version:content-type; bh=ckmgXBm4SyXxCNBGa10WMjSqjrP6S2tv46jAhOo6ZT4=; b=fuCUdvCMYTkqQi4cgC19n4rzn4dVRddeXBosa2A+Olp2odbcUGC9b7SbvGaYBvuuYV p5LqZGiqr7f1LwQv40muAknDSDwKPtAH5ZtnhiDTW+bij8CC+yuan5amPVbR9wFoNeTP NIhdr0V0GgrUHhixNosWc0NL8IYNfj+haxhidvkYdMRoMBjNBvkUCUScpLpPJRQDBZvm sYb8bSSjkSGxx6MitoPjMVQB8d3/M2bOUOjXP2xOBFyL7HtzYejqupVgW7pCOqeFUZzl 2fnAi9H1vtSvka4UVJElA88xwr3aCPl96KUgCjPXreeRqZPI161VFY0WPzobf3kjew4q sQIA== X-Gm-Message-State: ALoCoQnXEGcZgpjN6nf7kFTuhylcWJernFfGySgP/wea/d7hiSv/8VMt7JeWiKqPPaLdqfBdmiBg X-Received: by 10.236.128.195 with SMTP id f43mr2042594yhi.45.1400860015867; Fri, 23 May 2014 08:46:55 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id n59si201826yhi.6.2014.05.23.08.46.55 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 23 May 2014 08:46:55 -0700 (PDT) Received: from tomh.mtv.corp.google.com (tomh.mtv.corp.google.com [172.18.117.126]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id B685C31C942; Fri, 23 May 2014 08:46:55 -0700 (PDT) Received: by tomh.mtv.corp.google.com (Postfix, from userid 60832) id 79E682008D7; Fri, 23 May 2014 08:46:55 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by tomh.mtv.corp.google.com (Postfix) with ESMTP id 6813B200723; Fri, 23 May 2014 08:46:55 -0700 (PDT) Date: Fri, 23 May 2014 08:46:55 -0700 (PDT) From: Tom Herbert To: davem@davemloft.net, netdev@vger.kernel.org Subject: [PATCH 1/5 v3] sunrpc: Remove sk_no_check setting Message-ID: User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Setting sk_no_check to UDP_CSUM_NORCV seems to have no effect. Signed-off-by: Tom Herbert --- net/sunrpc/xprtsock.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c index 25a3dcf..1dec604 100644 --- a/net/sunrpc/xprtsock.c +++ b/net/sunrpc/xprtsock.c @@ -866,8 +866,6 @@ static void xs_reset_transport(struct sock_xprt *transport) xs_restore_old_callbacks(transport, sk); write_unlock_bh(&sk->sk_callback_lock); - sk->sk_no_check = 0; - trace_rpc_socket_close(&transport->xprt, sock); sock_release(sock); } @@ -2046,7 +2044,6 @@ static void xs_udp_finish_connecting(struct rpc_xprt *xprt, struct socket *sock) sk->sk_user_data = xprt; sk->sk_data_ready = xs_udp_data_ready; sk->sk_write_space = xs_udp_write_space; - sk->sk_no_check = UDP_CSUM_NORCV; sk->sk_allocation = GFP_ATOMIC; xprt_set_connected(xprt);