From patchwork Sun Mar 11 21:16:25 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 146018 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 819B9B6FA3 for ; Mon, 12 Mar 2012 08:16:34 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752518Ab2CKVQc (ORCPT ); Sun, 11 Mar 2012 17:16:32 -0400 Received: from mail1-relais-roc.national.inria.fr ([192.134.164.82]:29524 "EHLO mail1-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751412Ab2CKVQ2 (ORCPT ); Sun, 11 Mar 2012 17:16:28 -0400 X-IronPort-AV: E=Sophos;i="4.73,566,1325458800"; d="scan'208";a="148736515" Received: from 9.238.9.109.rev.sfr.net (HELO hadrien) ([109.9.238.9]) by mail1-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-SHA; 11 Mar 2012 22:16:26 +0100 Date: Sun, 11 Mar 2012 22:16:25 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: "Chas Williams (CONTRACTOR)" cc: Julia Lawall , kernel-janitors@vger.kernel.org, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] drivers/atm/eni.c: ensure arguments to request_irq and free_irq are compatible In-Reply-To: <201203112058.q2BKwBCS024617@cmf.nrl.navy.mil> Message-ID: References: <201203112058.q2BKwBCS024617@cmf.nrl.navy.mil> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Julia Lawall Convert calls to free_irq so that the second argument is the same as the last argument of the corresponding call to request_irq. Without this property, free_irq does nothing. Signed-off-by: Julia Lawall --- Version 2: change free_irq, not request_irq. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c index 956e9ac..485a11a 100644 --- a/drivers/atm/eni.c +++ b/drivers/atm/eni.c @@ -1873,7 +1873,7 @@ free_list: kfree(eni_dev->free_list); free_irq: - free_irq(eni_dev->irq, eni_dev); + free_irq(eni_dev->irq, dev); out: return error;