From patchwork Fri Jun 11 09:17:06 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Filip Aben X-Patchwork-Id: 55301 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C2F26B7D1B for ; Fri, 11 Jun 2010 19:17:21 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757681Ab0FKJRQ (ORCPT ); Fri, 11 Jun 2010 05:17:16 -0400 Received: from mailer2.option.com ([81.246.70.163]:3924 "EHLO mailer2.option.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755787Ab0FKJRP (ORCPT ); Fri, 11 Jun 2010 05:17:15 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AloFAOqbEUwKAAAZ/2dsb2JhbACSaY0CvWOFGAQ Received: from unknown (HELO smtp3.option.com) ([10.0.0.25]) by mailer2.option.local with ESMTP; 11 Jun 2010 11:17:11 +0200 Received: from hwr-marcaw.option.local ([10.30.11.17]) by smtp3.option.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 11 Jun 2010 11:17:12 +0200 Date: Fri, 11 Jun 2010 11:17:06 +0200 (CEST) From: f.aben@option.com X-X-Sender: filip@filip-linux To: davem@davemloft.net cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, j.dumon@option.com Subject: [PATCH] hso: remove setting of low_latency flag Message-ID: User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 X-OriginalArrivalTime: 11 Jun 2010 09:17:12.0783 (UTC) FILETIME=[E06D95F0:01CB0946] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch removes the setting of the low_latency flag. tty_flip_buffer_push() is occasionally being called in irq context, which causes a hang if the low_latency flag is set. Removing the low_latency flag only seems to impact the flush to ldisc, which will now be put on a workqueue. Signed-off-by: Filip Aben --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index 0a3c41f..4dd2351 100644 --- a/drivers/net/usb/hso.c +++ b/drivers/net/usb/hso.c @@ -1334,7 +1334,6 @@ static int hso_serial_open(struct tty_struct *tty, struct file *filp) /* check for port already opened, if not set the termios */ serial->open_count++; if (serial->open_count == 1) { - tty->low_latency = 1; serial->rx_state = RX_IDLE; /* Force default termio settings */ _hso_serial_set_termios(tty, NULL);