| Message ID | ae62eaeb325fee0990af04aee285fa26d57bef63.1556531633.git.igor.russkikh@aquantia.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=aquantia.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=AQUANTIA1COM.onmicrosoft.com header.i=@AQUANTIA1COM.onmicrosoft.com header.b="Rt4yoFne"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44t0dw1mW9z9s7T for <patchwork-incoming-netdev@ozlabs.org>; Mon, 29 Apr 2019 20:05:24 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727969AbfD2KFX (ORCPT <rfc822;patchwork-incoming-netdev@ozlabs.org>); Mon, 29 Apr 2019 06:05:23 -0400 Received: from mail-eopbgr810055.outbound.protection.outlook.com ([40.107.81.55]:40164 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727960AbfD2KFW (ORCPT <rfc822;netdev@vger.kernel.org>); Mon, 29 Apr 2019 06:05:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7X3XSCDrI2zSgUk8rpc17RZSvhCwcWtzm/HYLoO74JI=; b=Rt4yoFne1kSTFpBFsSCLHiVLdZ+bWMhozTF3+xFgIsLioN59taQG2O6/Mp+ywGxAbW7LGmTa8P5L+Szr7oJ37PrrkabmM6oVCDZq6l1GOu2eTHOBCaTuSE3CWgH6cj07Sa8G84kOd3RnIC6obzS0N3xkmbo4jWjSfAeuazP8K00= Received: from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by DM6PR11MB3644.namprd11.prod.outlook.com (20.178.230.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.12; Mon, 29 Apr 2019 10:04:50 +0000 Received: from DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::f035:2c20:5a61:7653]) by DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::f035:2c20:5a61:7653%3]) with mapi id 15.20.1835.010; Mon, 29 Apr 2019 10:04:50 +0000 From: Igor Russkikh <Igor.Russkikh@aquantia.com> To: "David S . Miller" <davem@davemloft.net> CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>, Nikita Danilov <Nikita.Danilov@aquantia.com>, Dmitry Bogdanov <Dmitry.Bogdanov@aquantia.com>, Igor Russkikh <Igor.Russkikh@aquantia.com> Subject: [PATCH v4 net-next 07/15] net: aquantia: improve ifup link detection Thread-Topic: [PATCH v4 net-next 07/15] net: aquantia: improve ifup link detection Thread-Index: AQHU/nL7zfgTnQQt7EGGNvGrV2rn2A== Date: Mon, 29 Apr 2019 10:04:50 +0000 Message-ID: <ae62eaeb325fee0990af04aee285fa26d57bef63.1556531633.git.igor.russkikh@aquantia.com> References: <cover.1556531633.git.igor.russkikh@aquantia.com> In-Reply-To: <cover.1556531633.git.igor.russkikh@aquantia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1PR05CA0189.eurprd05.prod.outlook.com (2603:10a6:3:f9::13) To DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8fd97874-ef7b-454c-9676-08d6cc8a1e01 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:DM6PR11MB3644; x-ms-traffictypediagnostic: DM6PR11MB3644: x-microsoft-antispam-prvs: <DM6PR11MB3644BC7CA4D308D0462DB60C98390@DM6PR11MB3644.namprd11.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:475; x-forefront-prvs: 0022134A87 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(136003)(346002)(376002)(396003)(39840400004)(189003)(199004)(6512007)(2906002)(5660300002)(71200400001)(6486002)(99286004)(53936002)(26005)(25786009)(44832011)(71190400001)(14454004)(50226002)(4326008)(3846002)(66556008)(64756008)(66446008)(36756003)(8936002)(73956011)(72206003)(66946007)(54906003)(66476007)(7736002)(6116002)(6436002)(81166006)(86362001)(6506007)(478600001)(81156014)(8676002)(97736004)(305945005)(107886003)(386003)(316002)(118296001)(68736007)(102836004)(6916009)(76176011)(476003)(186003)(2616005)(486006)(4744005)(256004)(11346002)(52116002)(446003)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3644; H:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: +Tp9TEvjSAnmn8wW9EhGclD06xNHt4copoIwCdo6RwmJW98P5DeheqRRu7f8R/xvp/p4NHulggDc/LmV04OFK2lgfrFCK3OSodNY/Gn5r09nMg6gPCthFK0pcHugNXxTk2GjXOHWpxQdB6g3e27SP/7sPA6D0O1UB7oHiwjJdSTawNWJxEjeVYj4/BmoKQi1/Dy1d9g9T/C/mft+aG35iDMY9kCCIi7W+G07TQ7/hUgMuzMn8gyeZXHCGaSBsFIGClFxBhzhtKebMYYpPauVdSpLwNh9O7rYUCXq1Ux+t0INKwbTvuJi+9SvpVvEmGV5LgTCiLqKgbujvvn67B6k5XIXA94p9oXDdV8eNxBKiqNgz+dujGNYeAyduAWDJQmqSvoZGN0hBZY97Gj/hO/lGfkAo3WZAAV7Y2LO7bsrqRg= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8fd97874-ef7b-454c-9676-08d6cc8a1e01 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2019 10:04:50.5250 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3644 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
| Series |
net: atlantic: Aquantia driver updates 2019-04
|
expand
|
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c index 0251566b66af..6de0d1c0ed79 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c @@ -355,8 +355,7 @@ int aq_nic_start(struct aq_nic_s *self) if (err) goto err_exit; timer_setup(&self->service_timer, aq_nic_service_timer_cb, 0); - mod_timer(&self->service_timer, jiffies + - AQ_CFG_SERVICE_TIMER_INTERVAL); + aq_nic_service_timer_cb(&self->service_timer); if (self->aq_nic_cfg.is_polling) { timer_setup(&self->polling_timer, aq_nic_polling_timer_cb, 0);
Original code detected link only after 1 sec is passed after up. Here we replace this with direct service callback which updates link status immediately Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com> --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)