| Message ID | a798f789-94a9-f1ac-1cba-276a2c517089@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net: phy: let genphy_c45_read_abilities also check aneg capability | expand |
Hello Heiner, On Fri, 22 Feb 2019 08:23:04 +0100 Heiner Kallweit <hkallweit1@gmail.com> wrote: >When using genphy_c45_read_abilities() as get_features callback we >also have to set the autoneg capability in phydev->supported. >@@ -336,6 +336,17 @@ int genphy_c45_pma_read_abilities(struct phy_device *phydev) This makes the helper not reading PMA-only registers, so the naming isn't really relevant anymore, but that's a small detail. Other than that, Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com> Thanks, Maxime
From: Heiner Kallweit <hkallweit1@gmail.com> Date: Fri, 22 Feb 2019 08:23:04 +0100 > When using genphy_c45_read_abilities() as get_features callback we > also have to set the autoneg capability in phydev->supported. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Applied, thanks.
diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c index 4835c96cb..f05ef267a 100644 --- a/drivers/net/phy/phy-c45.c +++ b/drivers/net/phy/phy-c45.c @@ -336,6 +336,17 @@ int genphy_c45_pma_read_abilities(struct phy_device *phydev) { int val; + linkmode_clear_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, phydev->supported); + if (phydev->c45_ids.devices_in_package & MDIO_DEVS_AN) { + val = phy_read_mmd(phydev, MDIO_MMD_AN, MDIO_STAT1); + if (val < 0) + return val; + + if (val & MDIO_AN_STAT1_ABLE) + linkmode_set_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, + phydev->supported); + } + val = phy_read_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_STAT2); if (val < 0) return val;
When using genphy_c45_read_abilities() as get_features callback we also have to set the autoneg capability in phydev->supported. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/phy/phy-c45.c | 11 +++++++++++ 1 file changed, 11 insertions(+)