From patchwork Mon Aug 28 18:52:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavel Belous X-Patchwork-Id: 806721 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=AQUANTIA1COM.onmicrosoft.com header.i=@AQUANTIA1COM.onmicrosoft.com header.b="m0rhx+wm"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xh1BV2nJgz9s9Y for ; Tue, 29 Aug 2017 04:53:38 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751523AbdH1Sxg (ORCPT ); Mon, 28 Aug 2017 14:53:36 -0400 Received: from mail-sn1nam01on0068.outbound.protection.outlook.com ([104.47.32.68]:28764 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751190AbdH1Sxe (ORCPT ); Mon, 28 Aug 2017 14:53:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=tTTfqme56ZWx1/x6pngnW0N1HEzrN8JOoNOG621dAxw=; b=m0rhx+wm0nwIfC3pnJFAgvBaEVoywzP7y4VA520NAyKu9gL25J+rb3lxTjhOnaHVCoNEUK1J8QFUUe8/WzhOpbGKXHvNvmm7qGtdO/y86FGqy6/JwNnI8LhcwvsrnYUy20vV0tXDCgAUd3JQhSkttWngVFk4MIHXfYRCoZcA86Y= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavel.Belous@aquantia.com; Received: from atltest07.rdc.aquantia.com (83.149.43.106) by CY1PR07MB2554.namprd07.prod.outlook.com (10.167.16.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1385.9; Mon, 28 Aug 2017 18:53:26 +0000 From: Pavel Belous To: "David S . Miller" Cc: netdev@vger.kernel.org, David Arcari , Igor Russkikh , Nadezhda Krupnina , Simon Edelhaus , Pavel Belous , Pavel Belous Subject: [PATCH net v2 6/6] net:ethernet:aquantia: Show info message if bad firmware version detected. Date: Mon, 28 Aug 2017 21:52:13 +0300 Message-Id: X-Mailer: git-send-email 2.7.4 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [83.149.43.106] X-ClientProxiedBy: HE1PR0202CA0019.eurprd02.prod.outlook.com (10.168.182.29) To CY1PR07MB2554.namprd07.prod.outlook.com (10.167.16.21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 668cfb48-afd4-4d2b-8b16-08d4ee461508 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY1PR07MB2554; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2554; 3:jW2uV7x5OysDL6GsxoZVilRjR5vwEMvKmsN/+B3u5sJi0WIP41E2XreVnNiWVXjX3vl72wIjNzUwGdEfQGaWzazzG3g4KaomT0jdShaaxPW4tO9sXQubHIdssw0BGB6aB/wL/zRYL0OjAAgtIhQ3U5TjTqeJA/JdpqveA4rKfOYYE0uI6qgZLwh31NVpZYKz0h6mRRyaC+BzJpDHQM6pwaGEX+zXK5rTOD/dCTHiu5QZGD1qbuugey/hligICQg0; 25:KYVdjzrzoImcDZOyUiRTH4T8n95fJOba96/KbIR4CkWOVjtqt22dF26kx/MmWku9RkV+W/j3oJBVkqlI5J9Z79GLMo5sQjsM/+0QITPyPol6ZGeI2aT2x6ReO7C1Upgr7V8xEm+fXfQF4/GHfLyORKvi+9aL55/RpIzRSyewcnvQQ7n9LlNz8aViLK2dqmoBZ/c/WtWI9weq1oDTzVEn+mLXD0t++p5ilIYTcvAw59UwL4VHJlQDK4W/83CUfLujfET4mVAgQJuhZ5PWjE0nSEQ3UhfjaWYF+2n+deh2qygA5AEboOU2EPmSeLUjuTDHzvxYanHzskodoyD8lelgYw==; 31:6ypnWkELWD3MsNGJRZ2eLABEjRcLHVGAfn3uISe1CTtt4caTMSMJDjdNxIIa0jxqJqC0Yfbhy0qoLVk3rn2iwSbDh73DD1uDkJztBRq6mW0+s3gI/zj9kHSBMEDAXKewLie7uoz1uEhhsjs/JXTOuyrQZWAeSYdo9smnsbrbHaxDs0WtrWBhvLN2zL/pbNlcHrcNgINlhDxkAzckelHNWTzZRjR9mGHQzPh8cBYuLXI= X-MS-TrafficTypeDiagnostic: CY1PR07MB2554: X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2554; 20:nj6gUGWR+KAD9cxwT3Mv6qkqibUQ2TxC/6jC3qIT/7M3yp6/8oxbcv08jvAquEbxH4I0mzKom+gTimOfHyCqqBr5VZMpW7w4LL0aQOCuFnp4v2rGw8yXOntpoIOTEGH82ZtwAiAHZGiju6J7cTrNJNrCGuDX1O6i8bDxE5E2ZyMDrpNwPVfo0rwTJ2fHF3XtKDo/r+YaVhlZDZnFzFz8ikv0mcogqn8Qj9PrS7qKxxYR3sLZsRKNp2H9OWCZ78c6gwiuXVbMOQ62I+eaAG43VEImhvH23zFKm48Ox9kwSVRqYAxRWLsJqg8sI8xI/neg8d2XxJb+5mxtOvn4d+B4P58nXxPW7me1CmzTKD9RUgtFxr3j3MIRpT0XjZo8Mo4TIoRHmbk/GCy6cOk5Pvy75djxkvgMr0CFvWXQxz1munYkeWJRRNRa57+u/QG4t+yZZ1ST1BYOfNMASf09u7H5k1D9Sb/zoUt8nHijB7HWxxTA9GXjL1WqewmJeu4PmLSs; 4:Hx7EYt95EX2qcPH/tKChD5aiDjxwnbwezUZpXp8B1LIkVi6s2oic1zlFgyrOk/e2GMckBycsfW0MPk+zP9Megi2ceQhVFaQNHqGJ2QdvOxEUEM380/k8fMkFN6UGb45ttVrzK/AtVbzlXM01GqhcB62eCWxqmN7KmcfrzDcrRiCWX4yN5dpZ0dPyDPd7iXNrlsEI9HflBAqz68j76x7LpA7OAs+kDDylySZp+hXpEfN95Tn46h17+n+VrsFA8Mj4 X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6041248)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR07MB2554; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR07MB2554; X-Forefront-PRVS: 0413C9F1ED X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7370300001)(4630300001)(6009001)(189002)(199003)(54906002)(6916009)(50226002)(189998001)(36756003)(2950100002)(5003940100001)(106356001)(25786009)(86362001)(33646002)(7736002)(8676002)(66066001)(81156014)(305945005)(81166006)(50466002)(48376002)(47776003)(53936002)(478600001)(118296001)(72206003)(107886003)(76176999)(50986999)(2906002)(68736007)(6486002)(105586002)(6116002)(110136004)(6666003)(5660300001)(3846002)(15650500001)(7350300001)(4326008)(101416001)(97736004)(42186005); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2554; H:atltest07.rdc.aquantia.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2554; 23:xd1oH5zFZyzMiR/n9u+4pXWTyXgD7cSFVSv/HlkG/1mcXVFbPZQLOOyfpLXWA8bxvvB7ZErOVM81TMlmpBj56IvlwX72j2i+PS/ajJRogfSFlHn7V9b3owWBERQUJS31O+B3aQ8Yeh/8mSihqye5Y1CDvYM+UFjWnM4y+zrnxD5Jv4bvL9uG/cYgGBDcew2l47g+6o3/KAJ4T7CJCw63Dk5L1UZzwWyk2VZtPaS1ykmlmk+uuxRXqg/KmALnWlmjtCY5K7QmcID2nosEnbugeMJywh3uAEAlO8Q1EHYZD6IXMm08UeHQHvUFM+RSq/USlt4EuwkBM5xdplFrrTIHmTIW0eBbY+gxVp1NBE4hhmvvqZ4InaDbUd9UmBKF/rPyJGM2dSlJ8+gXuEdyyIhgPRzafy/oMIlcjdwIYv1caw30fbTQZttcqleGH82jqE/ph/N1orCW/e474BP8VbJ92cCTM5cmx6YQthpxOirSwToITjuJVmz9VR4UGqPhcCu2ALplZdN6Fc1+zXuOCwQ1K/46ZftzZyExsFtEPCzVbITO29q438d+yXvhGZ6HE1KOUX6eBO6Z5W08hJ+rWD3G0DicbThqOJ9dKL/4YIysVVgw4IIB3AuKpuhBwNcqG5Ln3hVM0fhcKDttljkdj0KO1AqHF6V+ooTXXW+kECYCct3Ata9vB0amxyD3bu+w5Zo878ePFBrhNZKEAqJ+K41paKdvV7uquyif9nBUETfP7sPRenvoo9CRbhUSAXCvbPenahD6qSue9NJ/PTtnsd0Or/gGjkuutZGzu08Yj2WN6ffx5VNU5XxQBJNb0XBqIRmPcdT7L3DgWKMG2cw40t5SP4RHA6v/kmkPzOoOF1WA4djcghp2MjvIGO0kIiIisixwqmgNvWZqV6BJpr/WljPVvn3Jx88rsXtDxjy4YspU+vfyiDPQ8tQ/PzfX7QWgIumiWLaAQeR822cniaz1PZC05hyGQ4lBWkt9yFLyDIs35gzAlBF3QBugfcGSKc60qjm7BIDRwn1l+TFPZT2JydfwIvtZyuaxhpxzdRrLazFwWlhNiqrfgdNDtsGbf8TZp7ncNaa1ZBEfwwWIuf7z85e/kQymHkpCQORMZl4DfbCrkAUxAWYvs/SACkgj+w1bWylArAo/O1hPcXt6sRhPaJPKkQ== X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2554; 6:upcf8O07mH/SgPrcZVoaD8QNyLo6xeJ0zWkgdr5NaPJr0OsAKTWXadpUfTngZZROpBlvwGpfv1Cj9MSG2yB+8t9KGiL7S0l/Uyw34Glm4yZe25QFJW/GXT0vBpsPYS9lPR264DdtR01CJLrZ38M1HEXphQv14/DsErzDic4Ifxo/wduKiu1wvHeJjCBFeQk3Rdp+5Grt6QpIESTV/ix4b6E5BRIMxQqHv80vzktymRmKrMKK2EoSXorSJbzTc/v7u4yYdikZJBhbtbeVpNpRBsFBCubM7A+5L2FzetW5SbWBxjjIrbOjS8HPGdSKMg+TnVv9YZnEP5R70qeylf+aWA==; 5:AKxEga+ahDOlCyOpWTViGt2/t01KLdnTO3bLAJt/4FceSvVc9VJ8U89M84BFx79xl4tcOZAI1PO8Rug1hxGMpGsdB7KpHsMckllopd66Im2LgIZjh5k3627+r8VhqzRZ5agK0dFI9DgrDjPhTSTz0w==; 24:RFdteudDlBNnH3hOZhtYFmUKgvIlmKzzbLoA33RKW4ukx3IgPwZupIQ3E/s1iHFB8tlEQcnhzNfWSVGIdfHV77zIqj0Z+HnoLHMFTBdzahA=; 7:Vy92zxlOJjsQ0nRff9V3LZiprdPDmHyMPo5gIe7fVlrGna+smsvsDxlSFmUrMR7Vyw6JfK8sJxDwnslzYWjWiD5urk6Kr2r8vSCP/WHo94mdnte/PnUyIJXwP2fmFs+zUsRA1GQanxXq0bXYex1+I2aZV+/t5vYEyI3ZG4HqR3X4Rs+p5Qy9bKWik98/fUSslnDQvDxkrk7NT4CKBHl0dWSmViVlZvx6HCuIqWRYCvI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Aug 2017 18:53:26.2408 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2554 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Pavel Belous We should inform user about wrong firmware version by printing message in dmesg. Fixes: 3d2ff7eebe26 ("net: ethernet: aquantia: Atlantic hardware abstraction layer") Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c index 7a1332e..4f5ec9a 100644 --- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c +++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c @@ -141,6 +141,12 @@ static int hw_atl_utils_init_ucp(struct aq_hw_s *self, err = hw_atl_utils_ver_match(aq_hw_caps->fw_ver_expected, aq_hw_read_reg(self, 0x18U)); + + if (err < 0) + pr_err("%s: Bad FW version detected: expected=%x, actual=%x\n", + AQ_CFG_DRV_NAME, + aq_hw_caps->fw_ver_expected, + aq_hw_read_reg(self, 0x18U)); return err; }