| Message ID | VI1PR04MB5567FAF88B84E9C77B93A40EEC090@VI1PR04MB5567.eurprd04.prod.outlook.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | net: phy: aquantia: readd XGMII support for AQR107 | expand |
On Wed, May 15, 2019 at 08:46:26AM +0000, Madalin-cristian Bucur wrote: > XGMII interface mode no longer works on AQR107 after the recent changes, > adding back support. Hi Madalin Please provide a Fixes: tag for fixes like this: Fixes: 570c8a7d5303 ("net: phy: aquantia: check for supported interface modes in config_init") I will let Heiner actually review it. Andrew
On 15.05.2019 10:46, Madalin-cristian Bucur wrote: > XGMII interface mode no longer works on AQR107 after the recent changes, > adding back support. > I'd like to check the configuration of the system with the AQR107. Which board is it, and which DT config is used? > Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> > --- > drivers/net/phy/aquantia_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/phy/aquantia_main.c b/drivers/net/phy/aquantia_main.c > index eed4fe3d871f..0fedd28fdb6e 100644 > --- a/drivers/net/phy/aquantia_main.c > +++ b/drivers/net/phy/aquantia_main.c > @@ -487,6 +487,7 @@ static int aqr107_config_init(struct phy_device *phydev) > /* Check that the PHY interface type is compatible */ > if (phydev->interface != PHY_INTERFACE_MODE_SGMII && > phydev->interface != PHY_INTERFACE_MODE_2500BASEX && > + phydev->interface != PHY_INTERFACE_MODE_XGMII && > phydev->interface != PHY_INTERFACE_MODE_10GKR) > return -ENODEV; > >
diff --git a/drivers/net/phy/aquantia_main.c b/drivers/net/phy/aquantia_main.c index eed4fe3d871f..0fedd28fdb6e 100644 --- a/drivers/net/phy/aquantia_main.c +++ b/drivers/net/phy/aquantia_main.c @@ -487,6 +487,7 @@ static int aqr107_config_init(struct phy_device *phydev) /* Check that the PHY interface type is compatible */ if (phydev->interface != PHY_INTERFACE_MODE_SGMII && phydev->interface != PHY_INTERFACE_MODE_2500BASEX && + phydev->interface != PHY_INTERFACE_MODE_XGMII && phydev->interface != PHY_INTERFACE_MODE_10GKR) return -ENODEV;
XGMII interface mode no longer works on AQR107 after the recent changes, adding back support. Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com> --- drivers/net/phy/aquantia_main.c | 1 + 1 file changed, 1 insertion(+)