From patchwork Thu Jan 21 10:21:47 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 43423 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 857A3B7D09 for ; Thu, 21 Jan 2010 21:22:34 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752164Ab0AUKVw (ORCPT ); Thu, 21 Jan 2010 05:21:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751969Ab0AUKVw (ORCPT ); Thu, 21 Jan 2010 05:21:52 -0500 Received: from mgw1.diku.dk ([130.225.96.91]:58029 "EHLO mgw1.diku.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866Ab0AUKVu (ORCPT ); Thu, 21 Jan 2010 05:21:50 -0500 Received: from localhost (localhost [127.0.0.1]) by mgw1.diku.dk (Postfix) with ESMTP id DFA5C52C379; Thu, 21 Jan 2010 11:21:48 +0100 (CET) X-Virus-Scanned: amavisd-new at diku.dk Received: from mgw1.diku.dk ([127.0.0.1]) by localhost (mgw1.diku.dk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2jj1Ryc1J9a9; Thu, 21 Jan 2010 11:21:47 +0100 (CET) Received: from nhugin.diku.dk (nhugin.diku.dk [130.225.96.140]) by mgw1.diku.dk (Postfix) with ESMTP id A637452C373; Thu, 21 Jan 2010 11:21:47 +0100 (CET) Received: from ask.diku.dk (ask.diku.dk [130.225.96.225]) by nhugin.diku.dk (Postfix) with ESMTP id 627906DF893; Thu, 21 Jan 2010 11:17:05 +0100 (CET) Received: by ask.diku.dk (Postfix, from userid 3767) id 854E94F64; Thu, 21 Jan 2010 11:21:47 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by ask.diku.dk (Postfix) with ESMTP id 7BC974F3B; Thu, 21 Jan 2010 11:21:47 +0100 (CET) Date: Thu, 21 Jan 2010 11:21:47 +0100 (CET) From: Julia Lawall To: David Miller Cc: vladislav.yasevich@hp.com, sri@us.ibm.com, linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 4/9] net/sctp: Eliminate useless code In-Reply-To: <20100120.150343.236848237.davem@davemloft.net> Message-ID: References: <4B574702.4040602@hp.com> <20100120.150343.236848237.davem@davemloft.net> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Julia Lawall The variable newinet is initialized twice to the same (side effect-free) expression. Drop one initialization. A simplified version of the semantic match that finds this problem is: (http://coccinelle.lip6.fr/) // @forall@ idexpression *x; identifier f!=ERR_PTR; @@ x = f(...) ... when != x ( x = f(...,<+...x...+>,...) | * x = f(...) ) // Signed-off-by: Julia Lawall --- net/sctp/socket.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 67fdac9..f6d1e59 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -6359,7 +6359,7 @@ void sctp_copy_sock(struct sock *newsk, struct sock *sk, struct sctp_association *asoc) { struct inet_sock *inet = inet_sk(sk); - struct inet_sock *newinet = inet_sk(newsk); + struct inet_sock *newinet; newsk->sk_type = sk->sk_type; newsk->sk_bound_dev_if = sk->sk_bound_dev_if;