diff mbox

batman-adv: fix potential NULL pointer dereferencing

Message ID DUB123-W2663266CEA8296935E9450A0B30@phx.gbl
State Awaiting Upstream, archived
Delegated to: David Miller
Headers show

Commit Message

Mario Pirker Sept. 22, 2014, 9:11 a.m. UTC 
From b451e7317148e18bf6c5c8fd747d79ab34260354 Mon Sep 17 00:00:00 2001
From: Mario Pirker <mario.pirker@kellogg.ox.ac.uk>
Date: Tue, 16 Sep 2014 17:55:13 +0200
Subject: [PATCH] batman-adv: fix potential NULL pointer dereferencing

The call batadv_gw_node_get may return NULL. The return value has to
be sanity checked before the pointer is dereferenced.

Signed-off-by: Mario Pirker <mariopirker@hotmail.com>
---
 net/batman-adv/gateway_client.c | 5 +++++
 1 file changed, 5 insertions(+)

-- 
1.8.1.4 		 	   		  --
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/batman-adv/gateway_client.c b/net/batman-adv/gateway_client.c
index 90cff58..7ee0913 100644
--- a/net/batman-adv/gateway_client.c
+++ b/net/batman-adv/gateway_client.c
@@ -810,6 +810,11 @@  bool batadv_gw_out_of_range(struct batadv_priv *bat_priv,
                goto out;
 
        gw_node = batadv_gw_node_get(bat_priv, orig_dst_node);
+
+       /* gw_node can be NULL. We need to check before dereferencing */
+       if (gw_node == NULL)
+               goto out;
+
        if (!gw_node->bandwidth_down == 0)
                goto out;