| Message ID | CY4PR1701MB187834A07970380742371D78DF160@CY4PR1701MB1878.namprd17.prod.outlook.com |
|---|---|
| State | Changes Requested |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net,1/4] net:phy:smsc: enable PHY_RST_AFTER_CLK_EN if ref clock is not set | expand |
| Context | Check | Description |
|---|---|---|
| jkicinski/cover_letter | warning | Series does not have a cover letter |
| jkicinski/fixes_present | success | Link |
| jkicinski/patch_count | success | Link |
| jkicinski/tree_selection | success | Clearly marked for net |
| jkicinski/subject_prefix | success | Link |
| jkicinski/source_inline | success | Was 0 now: 0 |
| jkicinski/verify_signedoff | success | Link |
| jkicinski/module_param | success | Was 0 now: 0 |
| jkicinski/build_32bit | fail | Errors and warnings before: 4 this patch: 4 |
| jkicinski/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| jkicinski/verify_fixes | success | Link |
| jkicinski/checkpatch | fail | Link |
| jkicinski/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| jkicinski/header_inline | success | Link |
| jkicinski/stable | success | Stable not CCed |
On Tue, 27 Oct 2020 23:27:42 +0000, Badel, Laurent wrote: > Subject: [PATCH net 2/4] net:phy:smsc: expand documentation of clocks property > > Description: The ref clock is managed differently when added to the DT > entry for SMSC PHY. Thus, specify this more clearly in the documentation. > > Signed-off-by: Laurent Badel <laurentbadel@eaton.com> > --- > Documentation/devicetree/bindings/net/smsc-lan87xx.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>
> ----------------------------- Eaton Industries Manufacturing GmbH ~ Registered place of business: Route de la Longeraie 7, 1110, Morges, Switzerland ----------------------------- -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: Friday, October 30, 2020 8:19 PM > To: Badel, Laurent <LaurentBadel@eaton.com> > Cc: davem@davemloft.net; fugang.duan@nxp.com; andrew@lunn.ch; > lgirdwood@gmail.com; m.felsch@pengutronix.de; robh+dt@kernel.org; > kuba@kernel.org; linux@armlinux.org.uk; richard.leitner@skidata.com; > netdev@vger.kernel.org; Quette, Arnaud <ArnaudQuette@Eaton.com>; > p.zabel@pengutronix.de; devicetree@vger.kernel.org; f.fainelli@gmail.com; > broonie@kernel.org; Heiner Kallweit <hkallweit1@gmail.com> > Subject: [EXTERNAL] Re: [PATCH net 2/4] net:phy:smsc: expand > documentation of clocks property > > On Tue, 27 Oct 2020 23:27:42 +0000, Badel, Laurent wrote: > > Subject: [PATCH net 2/4] net:phy:smsc: expand documentation of clocks > > property > > > > Description: The ref clock is managed differently when added to the DT > > entry for SMSC PHY. Thus, specify this more clearly in the documentation. > > > > Signed-off-by: Laurent Badel <laurentbadel@eaton.com> > > --- > > Documentation/devicetree/bindings/net/smsc-lan87xx.txt | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > Acked-by: Rob Herring <robh@kernel.org> Thank you very much. I'm guessing perhaps I should re-send this as a single patch since there are issues with the patch series? I realize now that I should have splitted things differently.
On 11/4/2020 4:11 AM, Badel, Laurent wrote: > > > > ----------------------------- > Eaton Industries Manufacturing GmbH ~ Registered place of business: Route de la Longeraie 7, 1110, Morges, Switzerland > > ----------------------------- > > -----Original Message----- >> From: Rob Herring <robh@kernel.org> >> Sent: Friday, October 30, 2020 8:19 PM >> To: Badel, Laurent <LaurentBadel@eaton.com> >> Cc: davem@davemloft.net; fugang.duan@nxp.com; andrew@lunn.ch; >> lgirdwood@gmail.com; m.felsch@pengutronix.de; robh+dt@kernel.org; >> kuba@kernel.org; linux@armlinux.org.uk; richard.leitner@skidata.com; >> netdev@vger.kernel.org; Quette, Arnaud <ArnaudQuette@Eaton.com>; >> p.zabel@pengutronix.de; devicetree@vger.kernel.org; f.fainelli@gmail.com; >> broonie@kernel.org; Heiner Kallweit <hkallweit1@gmail.com> >> Subject: [EXTERNAL] Re: [PATCH net 2/4] net:phy:smsc: expand >> documentation of clocks property >> >> On Tue, 27 Oct 2020 23:27:42 +0000, Badel, Laurent wrote: >>> Subject: [PATCH net 2/4] net:phy:smsc: expand documentation of clocks >>> property >>> >>> Description: The ref clock is managed differently when added to the DT >>> entry for SMSC PHY. Thus, specify this more clearly in the documentation. >>> >>> Signed-off-by: Laurent Badel <laurentbadel@eaton.com> >>> --- >>> Documentation/devicetree/bindings/net/smsc-lan87xx.txt | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >> >> Acked-by: Rob Herring <robh@kernel.org> > > Thank you very much. > I'm guessing perhaps I should re-send this as a single patch since there > are issues with the patch series? > I realize now that I should have splitted things differently. There are several things with your patch series that make it very hard to be followed or to even know what is the latest version of your patch series. If you can resubmit everything targeting the 'net' tree along with a cover letter explaining the differences between v1 and v2 that would help. Please make sure that all of your patches reference the cover letter's Message-Id which is the default if you use git format-patch --cover-letter . Thanks
> ----------------------------- Eaton Industries Manufacturing GmbH ~ Registered place of business: Route de la Longeraie 7, 1110, Morges, Switzerland ----------------------------- -----Original Message----- > From: Florian Fainelli <f.fainelli@gmail.com> > Sent: Wednesday, November 04, 2020 5:02 PM > To: Badel, Laurent <LaurentBadel@eaton.com>; Rob Herring > <robh@kernel.org> > Cc: davem@davemloft.net; fugang.duan@nxp.com; andrew@lunn.ch; > lgirdwood@gmail.com; m.felsch@pengutronix.de; robh+dt@kernel.org; > kuba@kernel.org; linux@armlinux.org.uk; richard.leitner@skidata.com; > netdev@vger.kernel.org; Quette, Arnaud <ArnaudQuette@Eaton.com>; > p.zabel@pengutronix.de; devicetree@vger.kernel.org; broonie@kernel.org; > Heiner Kallweit <hkallweit1@gmail.com> > Subject: Re: [EXTERNAL] Re: [PATCH net 2/4] net:phy:smsc: expand > documentation of clocks property > > > > On 11/4/2020 4:11 AM, Badel, Laurent wrote: > > > > > > > ----------------------------- > > Eaton Industries Manufacturing GmbH ~ Registered place of business: > > Route de la Longeraie 7, 1110, Morges, Switzerland > > > > ----------------------------- > > > > -----Original Message----- > >> From: Rob Herring <robh@kernel.org> > >> Sent: Friday, October 30, 2020 8:19 PM > >> To: Badel, Laurent <LaurentBadel@eaton.com> > >> Cc: davem@davemloft.net; fugang.duan@nxp.com; andrew@lunn.ch; > >> lgirdwood@gmail.com; m.felsch@pengutronix.de; robh+dt@kernel.org; > >> kuba@kernel.org; linux@armlinux.org.uk; richard.leitner@skidata.com; > >> netdev@vger.kernel.org; Quette, Arnaud <ArnaudQuette@Eaton.com>; > >> p.zabel@pengutronix.de; devicetree@vger.kernel.org; > >> f.fainelli@gmail.com; broonie@kernel.org; Heiner Kallweit > >> <hkallweit1@gmail.com> > >> Subject: [EXTERNAL] Re: [PATCH net 2/4] net:phy:smsc: expand > >> documentation of clocks property > >> > >> On Tue, 27 Oct 2020 23:27:42 +0000, Badel, Laurent wrote: > >>> Subject: [PATCH net 2/4] net:phy:smsc: expand documentation of > >>> clocks property > >>> > >>> Description: The ref clock is managed differently when added to the > >>> DT entry for SMSC PHY. Thus, specify this more clearly in the > documentation. > >>> > >>> Signed-off-by: Laurent Badel <laurentbadel@eaton.com> > >>> --- > >>> Documentation/devicetree/bindings/net/smsc-lan87xx.txt | 3 ++- > >>> 1 file changed, 2 insertions(+), 1 deletion(-) > >>> > >> > >> Acked-by: Rob Herring <robh@kernel.org> > > > > Thank you very much. > > I'm guessing perhaps I should re-send this as a single patch since > > there are issues with the patch series? > > I realize now that I should have splitted things differently. > > There are several things with your patch series that make it very hard to be > followed or to even know what is the latest version of your patch series. If > you can resubmit everything targeting the 'net' tree along with a cover letter > explaining the differences between v1 and v2 that would help. Please make > sure that all of your patches reference the cover letter's Message-Id which is > the default if you use git format-patch --cover-letter . > > Thanks > -- > Florian I will make sure to give details as you suggested, sorry for the trouble and thank you for your time reviewing. Laurent
diff --git a/Documentation/devicetree/bindings/net/smsc-lan87xx.txt b/Documentation/devicetree/bindings/net/smsc-lan87xx.txt index a8d0dc9a8c0e..43f4763f0d3d 100644 --- a/Documentation/devicetree/bindings/net/smsc-lan87xx.txt +++ b/Documentation/devicetree/bindings/net/smsc-lan87xx.txt @@ -7,7 +7,8 @@ Optional properties: - clocks: The clock used as phy reference clock and is connected to phy - pin XTAL1/CLKIN. + pin XTAL1/CLKIN. If set, the clock will be managed by the PHY + driver and remain enabled for the lifetime of the driver. - smsc,disable-energy-detect: If set, do not enable energy detect mode for the SMSC phy.
Subject: [PATCH net 2/4] net:phy:smsc: expand documentation of clocks property Description: The ref clock is managed differently when added to the DT entry for SMSC PHY. Thus, specify this more clearly in the documentation. Signed-off-by: Laurent Badel <laurentbadel@eaton.com> --- Documentation/devicetree/bindings/net/smsc-lan87xx.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)