From patchwork Tue Aug 28 13:12:00 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 180486 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C58CB2C026F for ; Tue, 28 Aug 2012 23:12:09 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752441Ab2H1NMD (ORCPT ); Tue, 28 Aug 2012 09:12:03 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:36079 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752280Ab2H1NMB (ORCPT ); Tue, 28 Aug 2012 09:12:01 -0400 Received: by qcro28 with SMTP id o28so3331648qcr.19 for ; Tue, 28 Aug 2012 06:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=JEY6HpTQ1WcPlmayt5Lv9WP3doiavxvGBetGZ6FNpEU=; b=a0H9fAradicvkyXPiLtHxVE9jMNtvE25k5/DC7cnIU86rLkXie9K5kmyKymSZtO1lU z1m+xXYbB19bXCOg3cofdgg1ClHOyC8923k1mN72qNKtLuNzl3yDevRWEZ4b9tlSkcxh xajwWChbEP0ZS1DjdBRZdCzNsjjaJHyM7f7Ar5vS7lex/3Y6SyaDCI2Fi/Tou8lYEIGZ dJRjOloMD9jJUYU5lET3sPhGTMcNnR1M8pMrN0Fwuq+5YD5IdI+HT8XNpCeWJ0uc00CP zrCHEAVlqP2/s881323FAB/5lpyEx6bq3itTEvG7V4oBnJq8BBUjW/wMDCzniv72gsv3 im4A== MIME-Version: 1.0 Received: by 10.229.135.202 with SMTP id o10mr8818658qct.19.1346159520376; Tue, 28 Aug 2012 06:12:00 -0700 (PDT) Received: by 10.229.146.194 with HTTP; Tue, 28 Aug 2012 06:12:00 -0700 (PDT) Date: Tue, 28 Aug 2012 21:12:00 +0800 Message-ID: Subject: [PATCH] rtlwifi: rtl8192c: remove pointless conditional before kfree_skb() From: Wei Yongjun To: Larry.Finger@lwfinger.net, chaoming_li@realsil.com.cn, linville@tuxdriver.com Cc: yongjun_wei@trendmicro.com.cn, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Wei Yongjun Remove pointless conditional before kfree_skb(). Signed-off-by: Wei Yongjun Acked-by: Larry Finger --- drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c index 44febfd..b627151 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c +++ b/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c @@ -577,8 +577,7 @@ static bool _rtl92c_cmd_send_packet(struct ieee80211_hw *hw, ring = &rtlpci->tx_ring[BEACON_QUEUE]; pskb = __skb_dequeue(&ring->queue); - if (pskb) - kfree_skb(pskb); + kfree_skb(pskb); spin_lock_irqsave(&rtlpriv->locks.irq_th_lock, flags);