From patchwork Thu Aug 23 07:28:19 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 179529 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E55112C00A2 for ; Thu, 23 Aug 2012 17:28:25 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756018Ab2HWH2V (ORCPT ); Thu, 23 Aug 2012 03:28:21 -0400 Received: from mail-qa0-f53.google.com ([209.85.216.53]:42502 "EHLO mail-qa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755894Ab2HWH2U (ORCPT ); Thu, 23 Aug 2012 03:28:20 -0400 Received: by qaas11 with SMTP id s11so299743qaa.19 for ; Thu, 23 Aug 2012 00:28:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=8xWv8IJXSFcfauAwNHf05NNASkkxDFha//lKQyCQpyw=; b=mA0hJP5w8zYoKlBdk2XLSQ7i2aScmY7x/m/swH4DjNMdLvNrSJRugAzKtshIFveBU2 yy1aZLDAa+JGuA6FxGia9HAAUTSPpBUsU3lTCP002lQlU6FMPZQgn9MSQgRYtkfDfOhg oqbUFw0qRtNHQz9V0Z5Gy9S9Q0tkzOIpQZAyhtIAcEghOQ7c1hyabFsnVymCeu+Bd2u/ qf01kA8J7V2t8ij4ziMXC9GdseiMhOL6UHCK5TxerIQUx03vNoEpjVP2o6v6oGRM+ml8 pllfZ+heL6I1lrWHPECc4hGstPxcAeXFDAAXxQfyTWU/iHoF/6ROEb8I+fOhfD5Amj8C j9nw== MIME-Version: 1.0 Received: by 10.224.184.20 with SMTP id ci20mr1454797qab.26.1345706899358; Thu, 23 Aug 2012 00:28:19 -0700 (PDT) Received: by 10.229.146.194 with HTTP; Thu, 23 Aug 2012 00:28:19 -0700 (PDT) Date: Thu, 23 Aug 2012 15:28:19 +0800 Message-ID: Subject: [PATCH net-next] w5100: using eth_hw_addr_random() for random MAC and set device flag From: Wei Yongjun To: davem@davemloft.net Cc: yongjun_wei@trendmicro.com.cn, netdev@vger.kernel.org Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Wei Yongjun Using eth_hw_addr_random() to generate a random Ethernet address (MAC) to be used by a net device and set addr_assign_type. Not need to duplicating its implementation. spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun --- drivers/net/ethernet/wiznet/w5100.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ethernet/wiznet/w5100.c b/drivers/net/ethernet/wiznet/w5100.c index a5826a3..2c08bf6 100644 --- a/drivers/net/ethernet/wiznet/w5100.c +++ b/drivers/net/ethernet/wiznet/w5100.c @@ -637,8 +637,7 @@ static int __devinit w5100_hw_probe(struct platform_device *pdev) if (data && is_valid_ether_addr(data->mac_addr)) { memcpy(ndev->dev_addr, data->mac_addr, ETH_ALEN); } else { - eth_random_addr(ndev->dev_addr); - ndev->addr_assign_type |= NET_ADDR_RANDOM; + eth_hw_addr_random(ndev); } mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);