From patchwork Mon Mar 11 14:40:14 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 226568 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4A7642C02B2 for ; Tue, 12 Mar 2013 01:40:23 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752714Ab3CKOkR (ORCPT ); Mon, 11 Mar 2013 10:40:17 -0400 Received: from mail-bk0-f53.google.com ([209.85.214.53]:57889 "EHLO mail-bk0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751868Ab3CKOkQ (ORCPT ); Mon, 11 Mar 2013 10:40:16 -0400 Received: by mail-bk0-f53.google.com with SMTP id j10so1761690bkw.12 for ; Mon, 11 Mar 2013 07:40:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:date:message-id:subject:from:to:cc :content-type; bh=ondxAT9L5dIP5+/m7djVvvWk9wwASJo32Owh6OCAyik=; b=Of5LRJRlklgxsITFAbktkHT4h9kT2zykWYz4gvRCk0BlM6NYMV9qbq9j/hl7VPm+jG s0pCKIolUyBAuyuzlCPE+vlen19dSKQQ2TOg0lNSDYJE/Zi877xsUW0NAzbIbkn/9laE f5VICCWPiWbEKPjyDF76Ep0SJwODQoF7oxZTNrX+dZn5dtrJkvnchM4VHKB7XivyUm45 t8IWsFnLxpVfJPu+vneQyrwqk0a1Nh08AJf5FmRFA2hDtFFI+Y4wVm9sxMROrbJr0ub2 WamXgv94A1hXb42ncWuSH5CG29lTjsdBJV+sknbpXBKl2UIZSc5uQUhS+HV+9Dt/suCF OxZw== MIME-Version: 1.0 X-Received: by 10.205.32.208 with SMTP id sl16mr4814345bkb.27.1363012814897; Mon, 11 Mar 2013 07:40:14 -0700 (PDT) Received: by 10.204.30.210 with HTTP; Mon, 11 Mar 2013 07:40:14 -0700 (PDT) Date: Mon, 11 Mar 2013 22:40:14 +0800 Message-ID: Subject: [PATCH -next] bnx2x: use list_move instead of list_del/list_add From: Wei Yongjun To: eilong@broadcom.com Cc: yongjun_wei@trendmicro.com.cn, netdev@vger.kernel.org Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Wei Yongjun Using list_move() instead of list_del() + list_add(). Signed-off-by: Wei Yongjun Acked-by: Ariel Elior --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c index 71fcef0..c32a066 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c @@ -556,8 +556,7 @@ static int bnx2x_vfop_config_list(struct bnx2x *bp, rc = bnx2x_config_vlan_mac(bp, vlan_mac); if (rc >= 0) { cnt += pos->add ? 1 : -1; - list_del(&pos->link); - list_add(&pos->link, &rollback_list); + list_move(&pos->link, &rollback_list); rc = 0; } else if (rc == -EEXIST) { rc = 0;