From patchwork Wed Sep 25 07:33:29 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 277723 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id AE89E2C0094 for ; Wed, 25 Sep 2013 17:33:34 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752757Ab3IYHdb (ORCPT ); Wed, 25 Sep 2013 03:33:31 -0400 Received: from mail-bk0-f48.google.com ([209.85.214.48]:54724 "EHLO mail-bk0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751146Ab3IYHda (ORCPT ); Wed, 25 Sep 2013 03:33:30 -0400 Received: by mail-bk0-f48.google.com with SMTP id my13so2077192bkb.7 for ; Wed, 25 Sep 2013 00:33:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=MVLSmkRiXQhcGfCdtWW98Ah3c/B7mDxpON/RuUxtYPQ=; b=lEJiWO2P1t0BtccwnVNKSWkMy3cT21AnzfjIwd3PAj3K0Ib2abyq1tMZOMYt+pDi5o wduExa9B7ZB22+ZTJ+NMaSoPnAHYDiRLLorNAQ3tY2BDB5XGEUAiana+8tZOlrZOQFP+ mD/gUlFTa19WrZK/eANeTjyapiV7aMUJcTxW2A8HtDI5IBZzUy7cUrQ2Zzz4esWWlbty R9RMjAy+OxkLv8R4vsvIhmW9WhVjXU7ecZYai+EhdrWE13F1isBx+5EiVpy42xBTO/81 8IAmokVoWjfr+24xtMGbD40NWmWaZirYLhnWhH4fUlG6F6mOcm2eUszJ/P3r4FAi/iZt oGWQ== MIME-Version: 1.0 X-Received: by 10.204.228.10 with SMTP id jc10mr12964738bkb.26.1380094409555; Wed, 25 Sep 2013 00:33:29 -0700 (PDT) Received: by 10.205.13.74 with HTTP; Wed, 25 Sep 2013 00:33:29 -0700 (PDT) Date: Wed, 25 Sep 2013 15:33:29 +0800 Message-ID: Subject: [PATCH] moxa: drop free_irq of devm_request_irq allocated irq From: Wei Yongjun To: grant.likely@linaro.org, rob.herring@calxeda.com, davem@davemloft.net, jg1.han@samsung.com, jonas.jensen@gmail.com Cc: yongjun_wei@trendmicro.com.cn, netdev@vger.kernel.org Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Wei Yongjun irq allocated with devm_request_irq should not be freed using free_irq, because doing so causes a dangling pointer, and a subsequent double free. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/moxa/moxart_ether.c | 1 - 1 file changed, 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ethernet/moxa/moxart_ether.c b/drivers/net/ethernet/moxa/moxart_ether.c index 83c2091..9a7fcb5 100644 --- a/drivers/net/ethernet/moxa/moxart_ether.c +++ b/drivers/net/ethernet/moxa/moxart_ether.c @@ -531,7 +531,6 @@ static int moxart_remove(struct platform_device *pdev) struct net_device *ndev = platform_get_drvdata(pdev); unregister_netdev(ndev); - free_irq(ndev->irq, ndev); moxart_mac_free_memory(ndev); free_netdev(ndev);