From patchwork Tue Oct 30 07:31:01 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 195319 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id B41862C00A3 for ; Tue, 30 Oct 2012 18:31:19 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755707Ab2J3HbE (ORCPT ); Tue, 30 Oct 2012 03:31:04 -0400 Received: from mail-ia0-f174.google.com ([209.85.210.174]:63843 "EHLO mail-ia0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755283Ab2J3HbC (ORCPT ); Tue, 30 Oct 2012 03:31:02 -0400 Received: by mail-ia0-f174.google.com with SMTP id y32so4522742iag.19 for ; Tue, 30 Oct 2012 00:31:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=RDVxepMVC4FHQVHLzo3FirX9YCm9QJW38UYo48qk8ZI=; b=CGpu/VvccI0VGqiCJ0pBLzAZPKaXv4AK3mWk3TKQO+TwKpL7SST+qnyyDtLWwufRap pkdKs5O2zkQE30C4ZeO1q0uBKyyxUw1+U1aqouRDV4Ox7Q+pebmnIyY/qZZfkfD/tUR8 eHYObSTPm8/ecjB6nta9Gyxa35IKIj5xy/iJt91kzMvCnM6/Sq/S7I3G7NOevmSdDR0M V/jVoc3M1iV6D5GsIBRvyqQjtXtsNvpxD8bplXkgXH599pZ4H9jUMBBwSrBHe3kmipaN 065EABw1KLmsmbuFOx+URAuKN8AAyLFCB9o1N7Rw1UUDYWLX7rikQ41XqBJC5JDomMl/ 71vg== MIME-Version: 1.0 Received: by 10.50.47.234 with SMTP id g10mr671361ign.16.1351582261503; Tue, 30 Oct 2012 00:31:01 -0700 (PDT) Received: by 10.64.136.210 with HTTP; Tue, 30 Oct 2012 00:31:01 -0700 (PDT) In-Reply-To: References: <5afab1ebe83e4361f1fd75bbea0c559af195bf02.1351529738.git.viresh.kumar@linaro.org> <1351540778.2721.7.camel@bwh-desktop.uk.solarflarecom.com> Date: Tue, 30 Oct 2012 13:01:01 +0530 Message-ID: Subject: Re: [PATCH] net: dsa/slave: Fix compilation warnings From: Viresh Kumar To: Ben Hutchings Cc: davem@davemloft.net, linaro-dev@lists.linaro.org, patches@linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org X-Gm-Message-State: ALoCoQmcx6hWckgA57NyPI+/XmYrlBDz7NmAUuxWXFKzpc7zNl9lGUaLesvmV+jefLEpoHKPiLLT Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 30 October 2012 12:15, Viresh Kumar wrote: > And so, if we select NET_DSA from these tagging drivers, then only slave.c will > get compiled. Otherwise slave.c dsa.c dsa_core.c wouldn't be compiled and so > no warnings. If my above explanation/assumption is correct, then please review following patch: --------------------------x-----------------------x---------------- From: Viresh Kumar Date: Mon, 29 Oct 2012 22:19:14 +0530 Subject: [PATCH] net: dsa/slave: Fix compilation warnings Currently when none of CONFIG_NET_DSA_TAG_DSA, CONFIG_NET_DSA_TAG_EDSA and CONFIG_NET_DSA_TAG_TRAILER is defined, we get following compilation warnings: net/dsa/slave.c:51:12: warning: 'dsa_slave_init' defined but not used [-Wunused-function] net/dsa/slave.c:60:12: warning: 'dsa_slave_open' defined but not used [-Wunused-function] net/dsa/slave.c:98:12: warning: 'dsa_slave_close' defined but not used [-Wunused-function] net/dsa/slave.c:116:13: warning: 'dsa_slave_change_rx_flags' defined but not used [-Wunused-function] net/dsa/slave.c:127:13: warning: 'dsa_slave_set_rx_mode' defined but not used [-Wunused-function] net/dsa/slave.c:136:12: warning: 'dsa_slave_set_mac_address' defined but not used [-Wunused-function] net/dsa/slave.c:164:12: warning: 'dsa_slave_ioctl' defined but not used [-Wunused-function] Earlier approach to fix this was discussed here: lkml.org/lkml/2012/10/29/549 This is another approach to fix it. This is done by some changes in config options, which make more sense than the earlier approach. As, atleast one tagging option must always be selected for using net/dsa/ infrastructure, this patch selects NET_DSA from tagging configs instead of having it as an selectable config. Signed-off-by: Viresh Kumar --- drivers/net/dsa/Kconfig | 1 - net/dsa/Kconfig | 16 +++++++++------- 2 files changed, 9 insertions(+), 8 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig index dd151d5..96eae22 100644 --- a/drivers/net/dsa/Kconfig +++ b/drivers/net/dsa/Kconfig @@ -1,5 +1,4 @@ menu "Distributed Switch Architecture drivers" - depends on NET_DSA config NET_DSA_MV88E6XXX tristate diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig index 274791c..f7c6cef 100644 --- a/net/dsa/Kconfig +++ b/net/dsa/Kconfig @@ -1,5 +1,5 @@ config NET_DSA - tristate "Distributed Switch Architecture support" + tristate default n depends on EXPERIMENTAL && NETDEVICES && !S390 select PHYLIB @@ -8,19 +8,21 @@ config NET_DSA the Distributed Switch Architecture. -if NET_DSA +menu "Distributed Switch Architecture support" # tagging formats config NET_DSA_TAG_DSA - bool + bool "Original DSA packet tagging format" + select NET_DSt default n config NET_DSA_TAG_EDSA - bool + bool "Ethertype DSA packet tagging format" + select NET_DSA default n config NET_DSA_TAG_TRAILER - bool + bool "Trailer DSA packet tagging format" + select NET_DSA default n - -endif +endmenu