From patchwork Tue Aug 11 02:28:18 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: yalin wang X-Patchwork-Id: 505843 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 97A4A1401AD for ; Tue, 11 Aug 2015 12:28:39 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=i83hsB/U; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933528AbbHKC2Z (ORCPT ); Mon, 10 Aug 2015 22:28:25 -0400 Received: from mail-pd0-f178.google.com ([209.85.192.178]:35422 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933306AbbHKC2X convert rfc822-to-8bit (ORCPT ); Mon, 10 Aug 2015 22:28:23 -0400 Received: by pdrg1 with SMTP id g1so77891422pdr.2; Mon, 10 Aug 2015 19:28:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=L6jXg7OiqJloakwV3ket52R7MrztdaOt5vTAywATWHA=; b=i83hsB/U9NAVHEQ1vgJrZGP1SwqBeQQwX6dEWJeHtKV1IszKXEPz0Z5pkpmo3ihX4g kjPKht/HBSyaIn6h3da6Uu0SjGzIhBVg94BaSMDmssu3/sLkDxJ6sLRPh3fX3Nifhhdj 9rZVZHUVOlDcXlDTfYPA8l3FH1ixUAmxr18KuXry1js5iSuUwW3z3gwL/12wgZYiehOS eHjTmFsltYw4I5VLsOBwKd56mWXIxTLmK93Ilmg5OVXiY9moTfr480tgPttkdc+aTEfN awf9h8TMBZ6km4pHp4Cp65wAuxAOBqodjTGgiwTUrnzT3J7jO1uFiFr81uPoHiv5cZ1j 1v3w== X-Received: by 10.70.65.5 with SMTP id t5mr52241536pds.16.1439260103190; Mon, 10 Aug 2015 19:28:23 -0700 (PDT) Received: from [17.87.29.244] ([17.87.29.244]) by smtp.gmail.com with ESMTPSA id x3sm403970pdr.43.2015.08.10.19.28.19 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 10 Aug 2015 19:28:22 -0700 (PDT) Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Subject: [RFC V2] bmac:change to use bitrev8() generic function From: yalin wang In-Reply-To: <89DC2B55-8B16-4B35-8EE0-AAD912E273BA@gmail.com> Date: Tue, 11 Aug 2015 10:28:18 +0800 Cc: Tobias Klauser , "fabf@skynet.be" , "david@gibson.dropbear.id.au" , "davem@davemloft.net" , "benh@kernel.crashing.org" , "netdev@vger.kernel.org" , open list Message-Id: References: <9A81C947-6F69-4549-B1D0-58061D6976CE@gmail.com> <20150810114901.GS16878@distanz.ch> <063D6719AE5E284EB5DD2968C1650D6D1CB77DC9@AcuExch.aculab.com> <89DC2B55-8B16-4B35-8EE0-AAD912E273BA@gmail.com> To: David Laight X-Mailer: Apple Mail (2.2098) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This change to use generic bitrev8() for bmac driver. Signed-off-by: yalin wang --- drivers/net/ethernet/apple/bmac.c | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/apple/bmac.c b/drivers/net/ethernet/apple/bmac.c index a65d7a6..7f7a398 100644 --- a/drivers/net/ethernet/apple/bmac.c +++ b/drivers/net/ethernet/apple/bmac.c @@ -22,6 +22,7 @@ #include #include #include +#include #include #include #include @@ -805,18 +806,6 @@ static irqreturn_t bmac_txdma_intr(int irq, void *dev_id) } #ifndef SUNHME_MULTICAST -/* Real fast bit-reversal algorithm, 6-bit values */ -static int reverse6[64] = { - 0x0,0x20,0x10,0x30,0x8,0x28,0x18,0x38, - 0x4,0x24,0x14,0x34,0xc,0x2c,0x1c,0x3c, - 0x2,0x22,0x12,0x32,0xa,0x2a,0x1a,0x3a, - 0x6,0x26,0x16,0x36,0xe,0x2e,0x1e,0x3e, - 0x1,0x21,0x11,0x31,0x9,0x29,0x19,0x39, - 0x5,0x25,0x15,0x35,0xd,0x2d,0x1d,0x3d, - 0x3,0x23,0x13,0x33,0xb,0x2b,0x1b,0x3b, - 0x7,0x27,0x17,0x37,0xf,0x2f,0x1f,0x3f -}; - static unsigned int crc416(unsigned int curval, unsigned short nxtval) { @@ -871,7 +860,7 @@ bmac_addhash(struct bmac_data *bp, unsigned char *addr) if (!(*addr)) return; crc = bmac_crc((unsigned short *)addr) & 0x3f; /* Big-endian alert! */ - crc = reverse6[crc]; /* Hyperfast bit-reversing algorithm */ + crc = bitrev8((u8)crc) >> 2; if (bp->hash_use_count[crc]++) return; /* This bit is already set */ mask = crc % 16; mask = (unsigned char)1 << mask; @@ -886,7 +875,7 @@ bmac_removehash(struct bmac_data *bp, unsigned char *addr) /* Now, delete the address from the filter copy, as indicated */ crc = bmac_crc((unsigned short *)addr) & 0x3f; /* Big-endian alert! */ - crc = reverse6[crc]; /* Hyperfast bit-reversing algorithm */ + crc = bitrev8((u8)crc) >> 2; if (bp->hash_use_count[crc] == 0) return; /* That bit wasn't in use! */ if (--bp->hash_use_count[crc]) return; /* That bit is still in use */ mask = crc % 16;