From patchwork Thu Jun 29 23:57:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?TWFoZXNoIEJhbmRld2FyICjgpK7gpLngpYfgpLYg4KSs4KSC4KSh4KWH4KS14KS+4KSwKQ==?= X-Patchwork-Id: 782566 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wzGnV6pgvz9s8P for ; Fri, 30 Jun 2017 09:58:06 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="bb3DDXbz"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751858AbdF2X6D (ORCPT ); Thu, 29 Jun 2017 19:58:03 -0400 Received: from mail-it0-f43.google.com ([209.85.214.43]:32889 "EHLO mail-it0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751785AbdF2X6B (ORCPT ); Thu, 29 Jun 2017 19:58:01 -0400 Received: by mail-it0-f43.google.com with SMTP id 188so2785682itx.0 for ; Thu, 29 Jun 2017 16:58:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=8WhCwQNROr+T2xVKOhfn4nFDy1OOfToMYovMkgn4mro=; b=bb3DDXbzlBYm1QLer3BJK2+N670i96Kq9EJSVXZ3ukBVPHSJ69MWmmq6xlngwY7GE7 yJoebTMIYgPE7KmDsesMltH08asqvofNuIJ5KgVOTTq6n0LIdrEQYgP6OsH81t+fwlQf GNHUP1GzmqjgSZoYzw3/irxFTpmo24QrPltut9vmIItcrAieEZdrWN1mEJjHCdjgO9wQ vhNpQx5KPJ2HMtQkz4ZmCRmUrTW4GHYSPQMUPqFLYfbGUTciOYURG4myXh/Hm7LQP/ZZ mU2M3gZmBct1fgA4htt1x62qxE2JyNq+/OV04zPJQiTP8DxBlwg5KszM4wH7Czp0ss6l Fe3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=8WhCwQNROr+T2xVKOhfn4nFDy1OOfToMYovMkgn4mro=; b=SGRABraOOpVdmhSMYyfnkujlyigGCur07lWk+FBwRG7+XVFM1jbgZxEU6rKEcELKDi 4LzL++xB5uAtXjcpzb7475Mlxn5ez20IFr2MKzmlZfN9xZU78pNW1x84dJMxrSwxooFj 585TE4MrxqTGFJWBvdyJqGUPI+IvIRNcgaKfZoBqOgTtMEdyQHbwQ61LWNKav/hlFtrq 8kNmXJB/C1JVazNxQvMaqMgWjN8dmre1AxI8JLS/ptptq2rC/pgeY9hWP2i0oRU1M3xE mmoinmbhsTfQX3drcd60HYoo5UF3+cLPSBk1bI+k/H9XWM9itA3ejHZspOAS7UIcXMip y/kw== X-Gm-Message-State: AKS2vOxMeNShRftH7N3t4MGcxrBmKekuS9E7U/bFk+nU1dMqhj39sJZN NVCO1SL6K/zE0P/zRWJTstPSUv1ZtBIb X-Received: by 10.36.135.204 with SMTP id f195mr16527218ite.91.1498780680091; Thu, 29 Jun 2017 16:58:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.15.14 with HTTP; Thu, 29 Jun 2017 16:57:39 -0700 (PDT) From: =?UTF-8?B?TWFoZXNoIEJhbmRld2FyICjgpK7gpLngpYfgpLYg4KSs4KSC4KSh4KWH4KS14KS+4KSwKQ==?= Date: Thu, 29 Jun 2017 16:57:39 -0700 Message-ID: Subject: RFC: bring UP 'lo' by default after creating new netns To: Eric Dumazet , ebiederm@xmission.com, adobriyan@gmail.com, David Miller , xiyou.wangcong@gmail.com Cc: linux-netdev Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Creation of new network namespace is almost always followed up by bringing up the loopback device. ip netns add foo ip -netns foo link set lo up I'm not sure if there are any consequences of bringing the device UP at the creation of network-namespace. thanks, --mahesh.. diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c index 2178db8e47cd..ac0e86c9a17f 100644 --- a/net/core/net_namespace.c +++ b/net/core/net_namespace.c @@ -428,6 +428,11 @@ struct net *copy_net_ns(unsigned long flags, net_drop_ns(net); return ERR_PTR(rv); } + /* Set the loopback device UP */ + rtnl_lock(); + dev_open(net->loopback_dev); + rtnl_unlock(); + return net; }