From patchwork Thu Feb 7 19:32:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: syrine tlili X-Patchwork-Id: 218979 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 088242C0080 for ; Fri, 8 Feb 2013 06:32:17 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759174Ab3BGTcN (ORCPT ); Thu, 7 Feb 2013 14:32:13 -0500 Received: from mail-qc0-f180.google.com ([209.85.216.180]:57677 "EHLO mail-qc0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756283Ab3BGTcN (ORCPT ); Thu, 7 Feb 2013 14:32:13 -0500 Received: by mail-qc0-f180.google.com with SMTP id v28so1116480qcm.39 for ; Thu, 07 Feb 2013 11:32:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:reply-to:date:message-id:subject:from:to:cc :content-type; bh=62l68drSBSjlMf0c3fgbmV3RGcgt1YucRr5zXe3k5yc=; b=dgynv1UMGEIFoXzcscijH2d1JckeLHypfmBIxYmcITFF+TCRBIzSQIyQVSi7YoUBxI 5te1K7j6b5NxI6WQjR/FwbqNM1YchC5rRMnYlNlcE4ii0RArdJQMTY4WerzSydESQ8GR cbxSMl6igC2Tw/3L55HMdHdDgofUGv5pqdSHbFg3DuK/23SbML1rPtvrf3074iCyP+Hh YD1ix6j/FXKER9NfOtcMCim+gL50pEf1nSdnCzxxOBofeJqiuwTb9VoPMpgUHdj7IaTr QGqVGQOKTpq03igEnHrgWFrx1dZKzs2WsQ/xYSsROVKJeVRVF1ifkpt6ZzflLTHp79ML gvKg== MIME-Version: 1.0 X-Received: by 10.224.71.20 with SMTP id f20mr1159099qaj.91.1360265531362; Thu, 07 Feb 2013 11:32:11 -0800 (PST) Received: by 10.49.25.76 with HTTP; Thu, 7 Feb 2013 11:32:11 -0800 (PST) Reply-To: syrine.tl@gmail.com Date: Thu, 7 Feb 2013 20:32:11 +0100 Message-ID: Subject: Null pointers linux3.8-rc6 From: syrine tlili To: netdev@vger.kernel.org Cc: Jesper Juhl Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi: I would like to report some errors related to the usage of unchecked null pointers. I also suggest a set of patches to fix the detected errors. Syrine memset(adapter->int_cdb, 0, sizeof(adapter->int_cdb)); @@ -4482,6 +4484,11 @@ mega_internal_command(adapter_t *adapter, megacmd_t *mc, mega_passthru *pthru) scsi_free_command(GFP_KERNEL, scmd); return rval; + +err_out: + mutex_unlock(&adapter->int_mtx); + scsi_free_command(GFP_KERNEL, scmd); + return -ENOMEM; } --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/arch/x86/platform/efi/efi.c b/b/arch/x86/platform/efi/efi.c index 77cf009..e64c3f4 100644 --- a/a/arch/x86/platform/efi/efi.c +++ b/b/arch/x86/platform/efi/efi.c @@ -924,6 +924,8 @@ void __init efi_enter_virtual_mode(void) new_memmap = krealloc(new_memmap, (count + 1) * memmap.desc_size, GFP_KERNEL); + if (!new_memmap) + return -ENOMEM; memcpy(new_memmap + (count * memmap.desc_size), md, memmap.desc_size); count++; diff --git a/a/fs/ceph/mdsmap.c b/b/fs/ceph/mdsmap.c index 73b7d44..d04ab8b 100644 --- a/a/fs/ceph/mdsmap.c +++ b/b/fs/ceph/mdsmap.c @@ -132,6 +132,8 @@ struct ceph_mdsmap *ceph_mdsmap_decode(void **p, void *end) m->m_info[mds].export_targets = kcalloc(num_export_targets, sizeof(u32), GFP_NOFS); + if (m->m_info[mds].export_targets == NULL) + goto badmem; for (j = 0; j < num_export_targets; j++) m->m_info[mds].export_targets[j] = ceph_decode_32(&pexport_targets); diff --git a/a/drivers/isdn/mISDN/fsm.c b/b/drivers/isdn/mISDN/fsm.c index 26477d4..07040b2 100644 --- a/a/drivers/isdn/mISDN/fsm.c +++ b/b/drivers/isdn/mISDN/fsm.c @@ -34,6 +34,8 @@ mISDN_FsmNew(struct Fsm *fsm, fsm->jumpmatrix = kzalloc(sizeof(FSMFNPTR) * fsm->state_count * fsm->event_count, GFP_KERNEL); + if (!fsm->jumpmatrix) + return -ENOMEM; for (i = 0; i < fncount; i++) if ((fnlist[i].state >= fsm->state_count) || diff --git a/a/drivers/scsi/megaraid.c b/b/drivers/scsi/megaraid.c index 9504ec0..37b915f 100644 --- a/a/drivers/scsi/megaraid.c +++ b/b/drivers/scsi/megaraid.c @@ -4437,6 +4437,8 @@ mega_internal_command(adapter_t *adapter, megacmd_t *mc, mega_passthru *pthru) memset(scb, 0, sizeof(scb_t)); sdev = kzalloc(sizeof(struct scsi_device), GFP_KERNEL); + if (!sdev) + goto err_out; scmd->device = sdev;