From patchwork Thu Mar 18 08:55:35 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: amit salecha X-Patchwork-Id: 48011 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A3672B7CFD for ; Thu, 18 Mar 2010 19:55:47 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751630Ab0CRIzl (ORCPT ); Thu, 18 Mar 2010 04:55:41 -0400 Received: from avexch1.qlogic.com ([198.70.193.115]:18002 "EHLO avexch1.qlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751385Ab0CRIzk convert rfc822-to-8bit (ORCPT ); Thu, 18 Mar 2010 04:55:40 -0400 Received: from avexcashub1.qlogic.org ([10.1.4.112]) by avexch1.qlogic.com with Microsoft SMTPSVC(6.0.3790.1830); Thu, 18 Mar 2010 01:55:39 -0700 Received: from avexcashub2.qlogic.org (10.1.4.116) by avexcashub1.qlogic.org (10.1.4.161) with Microsoft SMTP Server (TLS) id 8.1.375.2; Thu, 18 Mar 2010 01:55:39 -0700 Received: from MNEXCASHUB2.qlogic.org (10.33.2.104) by avexcashub2.qlogic.org (10.1.4.162) with Microsoft SMTP Server (TLS) id 8.1.375.2; Thu, 18 Mar 2010 01:55:39 -0700 Received: from MNEXMB2.qlogic.org ([fe80::f1b2:c612:e539:41d2]) by MNEXCASHUB2.qlogic.org ([::1]) with mapi; Thu, 18 Mar 2010 03:55:38 -0500 From: Amit Salecha To: "Eric W. Biederman" , David Miller CC: "netdev@vger.kernel.org" , Ameen Rahman Date: Thu, 18 Mar 2010 03:55:35 -0500 Subject: RE: [PATCH] netxen: The driver doesn't work on NX_P3_B1 so cause probe to fail. Thread-Topic: [PATCH] netxen: The driver doesn't work on NX_P3_B1 so cause probe to fail. Thread-Index: AcrGdHnc9ULEtwVzQbyW5S39Qb/0TAAAtfFA Message-ID: <99737F4847ED0A48AECC9F4A1974A4B80CFEFED04B@MNEXMB2.qlogic.org> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 X-OriginalArrivalTime: 18 Mar 2010 08:55:39.0960 (UTC) FILETIME=[C8BBB380:01CAC678] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sorry for all the problem you faced. But you shouldn't add support of device which is not supported. Netxen is now owned by Qlogic. You should first contact Qlogic to solve your problem. Qlogic will take needed action based on problem. Please write to me, with detail problem description. -----Original Message----- From: Eric W. Biederman [mailto:ebiederm@xmission.com] Sent: Thursday, March 18, 2010 1:55 PM To: David Miller Cc: netdev@vger.kernel.org; Amit Salecha Subject: [PATCH] netxen: The driver doesn't work on NX_P3_B1 so cause probe to fail. I haven't been able to get link up on a NX_P3_B1 since 2.6.31. The driver complains about a firmware hang instead. When I asked I was told rev 0x41 was a preproduction rev. So disable support in the driver so no one is surprised the code doesn't work. Signed-off-by: Eric W. Biederman --- drivers/net/netxen/netxen_nic_main.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c index 08780ef..9a7a0f3 100644 --- a/drivers/net/netxen/netxen_nic_main.c +++ b/drivers/net/netxen/netxen_nic_main.c @@ -1246,8 +1246,8 @@ netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) int pci_func_id = PCI_FUNC(pdev->devfn); uint8_t revision_id; - if (pdev->revision >= NX_P3_A0 && pdev->revision < NX_P3_B1) { - pr_warning("%s: chip revisions between 0x%x-0x%x" + if (pdev->revision >= NX_P3_A0 && pdev->revision <= NX_P3_B1) { + pr_warning("%s: chip revisions between 0x%x-0x%x " "will not be enabled.\n", module_name(THIS_MODULE), NX_P3_A0, NX_P3_B1); return -ENODEV;