From patchwork Sat Jul 9 17:17:52 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGHFgiBNaXJvc8WCYXc=?= X-Patchwork-Id: 104002 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id DA1AB1007DF for ; Sun, 10 Jul 2011 03:18:36 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754570Ab1GIRS1 (ORCPT ); Sat, 9 Jul 2011 13:18:27 -0400 Received: from rere.qmqm.pl ([89.167.52.164]:51956 "EHLO rere.qmqm.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754222Ab1GIRRz (ORCPT ); Sat, 9 Jul 2011 13:17:55 -0400 Received: by rere.qmqm.pl (Postfix, from userid 1000) id 5180B13A7B; Sat, 9 Jul 2011 19:17:52 +0200 (CEST) Message-Id: <9325e72a4729d61dbd1368fec1d1be92c20f1236.1310229312.git.mirq-linux@rere.qmqm.pl> In-Reply-To: References: From: =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Subject: [PATCH 14/21] net: tg3: mark bad rx handler behaviour [strict refill!] MIME-Version: 1.0 To: netdev@vger.kernel.org Cc: Matt Carlson , Michael Chan Date: Sat, 9 Jul 2011 19:17:52 +0200 (CEST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This could use common rx handler code, but the code is too complex for a simple conversion. Just warn about its behaviour. Signed-off-by: Michał Mirosław --- drivers/net/tg3.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 8211b9a..c64b403 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -4973,6 +4973,8 @@ static int tg3_rx(struct tg3_napi *tnapi, int budget) skb_size = tg3_alloc_rx_skb(tp, tpr, opaque_key, *post_ptr); +#warning drops packets from rx queue head on memory pressure +#warning (like dev_skb_finish_rx_dma_refill() users) if (skb_size < 0) goto drop_it;