From patchwork Fri Jun 24 02:02:38 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 101711 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A992BB6F8E for ; Fri, 24 Jun 2011 12:03:01 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760292Ab1FXCCm (ORCPT ); Thu, 23 Jun 2011 22:02:42 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:60271 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760159Ab1FXCCk (ORCPT ); Thu, 23 Jun 2011 22:02:40 -0400 Received: by pzk9 with SMTP id 9so1513807pzk.19 for ; Thu, 23 Jun 2011 19:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:date:sender:message-id:from:to:cc:subject :user-agent:mime-version:content-type; bh=gwSN2fZ46hBRWs0NQGDZEpnwkPLmH+eTRdL0KM0Jq7Q=; b=K2/+sW6/JL9EQjr85AHT3ESTIIG+qgy7BOj3muqBTSdqWN3qSvNco0+BFuZatikXe2 9RyiVR67uVgYZqBmEXlseqOSEtZel7HFILaIsiZf15JUut6gbhCwQ8VdaUwrUyJvh6nR 3dA9OO/swcz3ahFHHb9v3/+L4a0R9j84QqQ9c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:sender:message-id:from:to:cc:subject:user-agent:mime-version :content-type; b=jqBRhv7s6zAI9nWd5ozeJVTTyjQ/4nJzMK3YGGz4Ggi4raB81Nc5SE/aepycm5LHL/ RJ18fxKPeBkgbd/Cgrk0nfEJjsjTsQbHf8I9P92iU2QDWuHKQdFGPeQx3QqeNeURCKUw Hek2LVQIiLxhVCmSeL8MxEUS23CF8z2Ce3ly0= Received: by 10.68.48.199 with SMTP id o7mr1552789pbn.5.1308880959035; Thu, 23 Jun 2011 19:02:39 -0700 (PDT) Received: from morimoto-Dell-XPS420.gmail.com (49.14.32.202.bf.2iij.net [202.32.14.49]) by mx.google.com with ESMTPS id k4sm1657697pbl.91.2011.06.23.19.02.37 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 23 Jun 2011 19:02:38 -0700 (PDT) Date: Thu, 23 Jun 2011 19:02:38 -0700 (PDT) Message-ID: <87pqm40yx3.wl%kuninori.morimoto.gx@gmail.com> From: Kuninori Morimoto To: "David S. Miller" Cc: Linux-Net , (RSO) shimoda Subject: [PATCH] net: sh_eth: tidyup compile warning User-Agent: SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-2022-JP-2?B?R29q?= =?ISO-2022-JP-2?B?GyQoRCtXGyhC?=) APEL/10.8 Emacs/23.2 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch tidyup below warning ${LINUX}/drivers/net/sh_eth.c:1773: warning: 'mdp' may be used uninitialized in this function Cc: Yoshihiro Shimoda Signed-off-by: Kuninori Morimoto --- drivers/net/sh_eth.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c index 8a72a97..96a629f 100644 --- a/drivers/net/sh_eth.c +++ b/drivers/net/sh_eth.c @@ -1770,7 +1770,7 @@ static int sh_eth_drv_probe(struct platform_device *pdev) int ret, devno = 0; struct resource *res; struct net_device *ndev = NULL; - struct sh_eth_private *mdp; + struct sh_eth_private *mdp = NULL; struct sh_eth_plat_data *pd; /* get base addr */ @@ -1888,7 +1888,7 @@ out_unregister: out_release: /* net_dev free */ - if (mdp->tsu_addr) + if (mdp && mdp->tsu_addr) iounmap(mdp->tsu_addr); if (ndev) free_netdev(ndev);