| Message ID | 85e28e89-0488-c7e2-8ea4-3feaeada22a4@solarflare.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] sfc: elide assignment of skb | expand |
From: Edward Cree <ecree@solarflare.com> Date: Tue, 18 Feb 2020 17:34:00 +0000 > Instead of assigning skb = segments before the loop, just pass > segments directly as the first argument to skb_list_walk_safe(). > > Signed-off-by: Edward Cree <ecree@solarflare.com> Applied.
diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c index 04d7f41d7ed9..696a77c20cb7 100644 --- a/drivers/net/ethernet/sfc/tx.c +++ b/drivers/net/ethernet/sfc/tx.c @@ -287,9 +287,8 @@ static int efx_tx_tso_fallback(struct efx_tx_queue *tx_queue, return PTR_ERR(segments); dev_consume_skb_any(skb); - skb = segments; - skb_list_walk_safe(skb, skb, next) { + skb_list_walk_safe(segments, skb, next) { skb_mark_not_on_list(skb); efx_enqueue_skb(tx_queue, skb); }
Instead of assigning skb = segments before the loop, just pass segments directly as the first argument to skb_list_walk_safe(). Signed-off-by: Edward Cree <ecree@solarflare.com> --- drivers/net/ethernet/sfc/tx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)