From patchwork Mon Jan 7 20:49:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 1021588 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Ja/Yo6Nn"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43YSDY65yvz9sCr for ; Tue, 8 Jan 2019 07:49:17 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727017AbfAGUtQ (ORCPT ); Mon, 7 Jan 2019 15:49:16 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:46848 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726767AbfAGUtP (ORCPT ); Mon, 7 Jan 2019 15:49:15 -0500 Received: by mail-wr1-f67.google.com with SMTP id l9so1831545wrt.13 for ; Mon, 07 Jan 2019 12:49:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=u3yVrY2y/yqmMl3nshtcThaobdlzxnrA0x1XjvN3w4Q=; b=Ja/Yo6NnCqjG7vobWlOPPIE8Qx9G3kH2OG4UW8CN8dBPqQcNJg1FTFEJZijsrY+N5c 1BkycWv3SzhjP6iw7Biwj4Yt8VNDmxcNM3MbKLCPOYDLC9u76StdTf56WgdCl6iz7fo9 ZKYASkQIv9f3d3s6TangQKh9QCYB2VzAc/6hxriJh1uK4mNJYV1iLcjzD0Z8XPmc/LjD K7O4/mK5+xkWIbbeTFQy8SUbRbG38qlu1vXUMCgEPKiQlLQ21Gi7GQHnWAqiopLQtpqo VrrM7gQ28eQXrUtIWvC5bT09OC+im6f3kiTYR78zeZAoGTqMgoNmNHmR5NJiJnzBf+Oe Qv1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=u3yVrY2y/yqmMl3nshtcThaobdlzxnrA0x1XjvN3w4Q=; b=iZRz453dDbjX0bZvnqkqRX2TKXvj2d3wQ6WDWYDoUJe5SUBM7XK4KPyi9JaPaOMwOM V6HYjf8P/0g/PMI8OaUzbXZyKJVOQ6ooJFjwqpOdJiRYwGLjPUq1L79bCIVZP8gUZ6Bv ne2m6Xts5j0J89k6rt0oGe4yv4rMo5r4W/039qOCRhlX7sTyrkThR8GY7JgS5LFIjsaJ Mn5Evdm+OkFF0Q8qPpVsptu1Pcbe8kxxopgF4YH5QhDCtrHuCNirEv/42Rf+k5XW0G9E Oj4Ninx6H7jzFuyDtS/QJWnP1jGHXVSzCRE42GimB5S3rTZMPmI39N4sC95vVdTDFHyq DYJQ== X-Gm-Message-State: AJcUukdBluShC2l7uW/vaLSGPl4x/LT5plrirR48ja6M/X4OVY+D+LNi MgY2GuTZyhyHdEWi3YchfuG9haVo X-Google-Smtp-Source: ALg8bN4NbrBFrj79Egyk1n0B+J9eG6DizXjY2IPtK9467H5at5qGRPxyDaM3eYVpnenYsjdt6cQVFw== X-Received: by 2002:a05:6000:120a:: with SMTP id e10mr53575893wrx.85.1546894153809; Mon, 07 Jan 2019 12:49:13 -0800 (PST) Received: from ?IPv6:2003:ea:8be2:e400:6944:e497:2993:7f74? (p200300EA8BE2E4006944E49729937F74.dip0.t-ipconnect.de. [2003:ea:8be2:e400:6944:e497:2993:7f74]) by smtp.googlemail.com with ESMTPSA id s8sm67094508wrn.44.2019.01.07.12.49.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Jan 2019 12:49:13 -0800 (PST) From: Heiner Kallweit Subject: [PATCH net] r8169: load Realtek PHY driver module before r8169 To: David Miller , Realtek linux nic maintainers Cc: "netdev@vger.kernel.org" Message-ID: <8110915c-a514-34e7-e4b3-1f00cae76aa5@gmail.com> Date: Mon, 7 Jan 2019 21:49:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 Content-Language: en-US Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This soft dependency works around an issue where sometimes the genphy driver is used instead of the dedicated PHY driver. The root cause of the issue isn't clear yet. People reported the unloading/re-loading module r8169 helps, and also configuring this soft dependency in the modprobe config files. Important just seems to be that the realtek module is loaded before r8169. Once this has been applied preliminary fix 38af4b903210 ("net: phy: add workaround for issue where PHY driver doesn't bind to the device") will be removed. Fixes: f1e911d5d0df ("r8169: add basic phylib support") Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 7fe918026..c6b98024b 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -708,6 +708,7 @@ module_param(use_dac, int, 0); MODULE_PARM_DESC(use_dac, "Enable PCI DAC. Unsafe on 32 bit PCI slot."); module_param_named(debug, debug.msg_enable, int, 0); MODULE_PARM_DESC(debug, "Debug verbosity level (0=none, ..., 16=all)"); +MODULE_SOFTDEP("pre: realtek"); MODULE_LICENSE("GPL"); MODULE_FIRMWARE(FIRMWARE_8168D_1); MODULE_FIRMWARE(FIRMWARE_8168D_2);