From patchwork Fri Jan 20 10:10:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Davide Caratti X-Patchwork-Id: 717574 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3v4c8r22psz9ryk for ; Fri, 20 Jan 2017 21:17:48 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751954AbdATKRq (ORCPT ); Fri, 20 Jan 2017 05:17:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42024 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751859AbdATKRp (ORCPT ); Fri, 20 Jan 2017 05:17:45 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0A1943D959; Fri, 20 Jan 2017 10:11:24 +0000 (UTC) Received: from dhcp-176-44.mxp.redhat.com (dhcp-176-44.mxp.redhat.com [10.32.176.44]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v0KABML8023926; Fri, 20 Jan 2017 05:11:22 -0500 From: Davide Caratti To: Stephen Hemminger , Gregoire Baron , Jiri Benc Cc: netdev@vger.kernel.org Subject: [PATCH iproute2 net-next v2] tc: m_csum: add support for SCTP checksum Date: Fri, 20 Jan 2017 11:10:10 +0100 Message-Id: <7e8e15a6e6f11133b4e22166d27d32ad8d5a83e7.1484906832.git.dcaratti@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 20 Jan 2017 10:11:24 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 'sctp' parameter can now be used as 'csum' target to enable CRC32c computation on SCTP packets. Signed-off-by: Davide Caratti --- Notes: V2 - update man/man8/tc-csum.8 to include 'sctp' target man/man8/tc-csum.8 | 7 +++++-- tc/m_csum.c | 11 ++++++++--- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/man/man8/tc-csum.8 b/man/man8/tc-csum.8 index 3a64c82..f4392a4 100644 --- a/man/man8/tc-csum.8 +++ b/man/man8/tc-csum.8 @@ -19,6 +19,7 @@ csum - checksum update action .BR tcp " |" .BR udp " |" .BR udplite " |" +.BR sctp " |" .IR SWEETS " }" .ti -8 @@ -43,9 +44,11 @@ IGMP header TCP header .RB ( tcp ), UDP header -.RB ( udp ") or" +.RB ( udp ), UDPLite header -.RB ( udplite ). +.RB ( udplite ") or" +SCTP header +.RB ( sctp ). .TP .B SWEETS These are merely syntactic sugar and ignored internally. diff --git a/tc/m_csum.c b/tc/m_csum.c index d5b1af6..0ee8cad 100644 --- a/tc/m_csum.c +++ b/tc/m_csum.c @@ -24,7 +24,7 @@ explain(void) { fprintf(stderr, "Usage: ... csum \n" "Where: UPDATE := []\n" - " TARGET := { ip4h | icmp | igmp | tcp | udp | udplite | }\n" + " TARGET := { ip4h | icmp | igmp | tcp | udp | udplite | sctp | }\n" " SWEETS := { and | or | \'+\' }\n"); } @@ -65,6 +65,9 @@ parse_csum_args(int *argc_p, char ***argv_p, struct tc_csum *sel) else if (matches(*argv, "udplite") == 0) sel->update_flags |= TCA_CSUM_UPDATE_FLAG_UDPLITE; + else if (matches(*argv, "sctp") == 0) + sel->update_flags |= TCA_CSUM_UPDATE_FLAG_SCTP; + else if ((matches(*argv, "and") == 0) || (matches(*argv, "or") == 0) || (matches(*argv, "+") == 0)) @@ -160,6 +163,7 @@ print_csum(struct action_util *au, FILE *f, struct rtattr *arg) char *uflag_4 = ""; char *uflag_5 = ""; char *uflag_6 = ""; + char *uflag_7 = ""; int uflag_count = 0; @@ -191,13 +195,14 @@ print_csum(struct action_util *au, FILE *f, struct rtattr *arg) CSUM_UFLAG_BUFFER(uflag_4, TCA_CSUM_UPDATE_FLAG_TCP, "tcp"); CSUM_UFLAG_BUFFER(uflag_5, TCA_CSUM_UPDATE_FLAG_UDP, "udp"); CSUM_UFLAG_BUFFER(uflag_6, TCA_CSUM_UPDATE_FLAG_UDPLITE, "udplite"); + CSUM_UFLAG_BUFFER(uflag_7, TCA_CSUM_UPDATE_FLAG_SCTP, "sctp"); if (!uflag_count) { uflag_1 = "?empty"; } - fprintf(f, "csum (%s%s%s%s%s%s) action %s\n", + fprintf(f, "csum (%s%s%s%s%s%s%s) action %s\n", uflag_1, uflag_2, uflag_3, - uflag_4, uflag_5, uflag_6, + uflag_4, uflag_5, uflag_6, uflag_7, action_n2a(sel->action)); fprintf(f, "\tindex %u ref %d bind %d", sel->index, sel->refcnt, sel->bindcnt);