diff mbox series

[3/5] wlcore: Return directly after a failed ieee80211_beacon_get() in wlcore_set_beacon_template()

Message ID 6ea50cb4-8871-6752-6275-50da266f0e7d@users.sourceforge.net
State Rejected, archived
Delegated to: David Miller
Headers show
Series wlcore: Fine-tuning for three function implementations | expand

Commit Message

SF Markus Elfring Oct. 29, 2017, 8:13 p.m. UTC 
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 29 Oct 2017 20:00:41 +0100

Return directly after a call of the function "ieee80211_beacon_get"
failed at the beginning.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/net/wireless/ti/wlcore/main.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Julian Calaby Oct. 30, 2017, 1:32 p.m. UTC | #1 
On Mon, Oct 30, 2017 at 7:13 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 29 Oct 2017 20:00:41 +0100
>
> Return directly after a call of the function "ieee80211_beacon_get"
> failed at the beginning.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Reviewed-by: Julian Calaby <julian.calaby@gmail.com>

Thanks,
diff mbox series

Patch

diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
index efea811c1c83..0365b5e40a8d 100644
--- a/drivers/net/wireless/ti/wlcore/main.c
+++ b/drivers/net/wireless/ti/wlcore/main.c
@@ -4018,10 +4018,8 @@  static int wlcore_set_beacon_template(struct wl1271 *wl,
 	struct sk_buff *beacon = ieee80211_beacon_get(wl->hw, vif);
 	u16 tmpl_id;
 
-	if (!beacon) {
-		ret = -EINVAL;
-		goto out;
-	}
+	if (!beacon)
+		return -EINVAL;
 
 	wl1271_debug(DEBUG_MASTER, "beacon updated");