From patchwork Thu Nov 16 04:27:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 838402 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ENgqzvx4"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ycpDJ5yM5z9s7g for ; Thu, 16 Nov 2017 15:29:20 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932580AbdKPE3S (ORCPT ); Wed, 15 Nov 2017 23:29:18 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:55866 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758656AbdKPE3A (ORCPT ); Wed, 15 Nov 2017 23:29:00 -0500 Received: by mail-pf0-f195.google.com with SMTP id 17so18694686pfn.12; Wed, 15 Nov 2017 20:29:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=mKIkFPAH8dfhxT2PuwoyNQrOAlcHd3smE1fgNj2pOms=; b=ENgqzvx4jtuvVW0DUwTxZtwr0x6tI44F0BgWSdoNNuvDCMc8bgR0UNeMsA5PMjpBj6 p/HCrNcqf7gi7kdDJxae8l7jpmK6mn8QhR7d0UMg7wZVnQH4GKVhKITqXVBIi+0n3dEx A12EULl7cXazFkUSSm73CQ9cqwtqPI35+36jlZGKzL7jHerh2U9XTryz/88EubkAz9cj pqNJTBVMvAt5Lurtn+8oT72ICEF9CHo3HIcFxzl95tRhFc0yCUvCkMbdgD3tpFCSoM5v MeCRJcmiYU6bN+KFMYQnb4S2oQWdSsyDSkiMo6jNh1GDyq+XBSQATw54/JYKg6d3JpGS nFAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=mKIkFPAH8dfhxT2PuwoyNQrOAlcHd3smE1fgNj2pOms=; b=WioI4oOpN28AP10tszhBKurIwq3EAkp60Gweh6ONdQr3vTgQfAvjBh+By9uYWX71Ia nQzUqM4AtH+dOV8PBUVnGZc8ymSlzkaNBMZD317xTRWLE0E3GETQ+i1CBvsHfX3iSAVO y1Chtq0HNpkQkHlpnNuslx3atxPmvLQJKXlZkYrkOHO4kuGEpSKO3T4rBOzRglaUXUcI cfBItCvqC3PSlRnkQQHL5hO3m4GlwlvPGhShERk3CWws1Wln2iWBAgzaF8zsJ7GMPefR btn51OJHy6jpwo/ma9rlNbTH58Ws1TslneLyP8VveZ/v620hqAKPzZA9OtPWOY1RuxHa RqkA== X-Gm-Message-State: AJaThX4ywwQ1xz7av+bexpTB40jg4ZQahQWtUHqRR9aJZDfI5S7ksTMe V5TAoEDKuHLPBvNVrHUxLk8= X-Google-Smtp-Source: AGs4zMbjkmLPwU1gMsGHwUNqD3NFvxABtvHcJVDQyEjSPWN7/ro7huUSAfHhCPYJOpycua4qD3dNNw== X-Received: by 10.99.159.25 with SMTP id g25mr420925pge.176.1510806539748; Wed, 15 Nov 2017 20:28:59 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m69sm421965pfc.27.2017.11.15.20.28.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 20:28:59 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 03/12] isdn: hisax: Fix pnp_irq's error checking for setup_diva_isapnp Date: Thu, 16 Nov 2017 09:57:20 +0530 Message-Id: <6e647b3996ac5e67c40f52c3ce2c55d8b044f44e.1510805781.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/diva.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/diva.c b/drivers/isdn/hisax/diva.c index 3fc94e7..bed749c 100644 --- a/drivers/isdn/hisax/diva.c +++ b/drivers/isdn/hisax/diva.c @@ -1094,7 +1094,7 @@ static int setup_diva_isapnp(struct IsdnCard *card) } card->para[1] = pnp_port_start(pnp_d, 0); card->para[0] = pnp_irq(pnp_d, 0); - if (!card->para[0] || !card->para[1]) { + if (card->para[0] == -1 || !card->para[1]) { printk(KERN_ERR "Diva PnP:some resources are missing %ld/%lx\n", card->para[0], card->para[1]); pnp_disable_dev(pnp_d);