| Message ID | 6dc5c41a-c981-114a-3b1a-42046da3a547@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net: phy: remove dead code from phy_sanitize_settings | expand |
From: Heiner Kallweit <hkallweit1@gmail.com> Date: Wed, 17 Apr 2019 00:13:09 +0200 > phy_sanitize_settings() is called from phy_start_aneg() only, and only > if phydev->autoneg isn't set. Therefore the removed code does nothing. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Applied.
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 5938c5acf..984de9872 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -214,10 +214,6 @@ static void phy_sanitize_settings(struct phy_device *phydev) { const struct phy_setting *setting; - /* Sanitize settings based on PHY capabilities */ - if (linkmode_test_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, phydev->supported)) - phydev->autoneg = AUTONEG_DISABLE; - setting = phy_find_valid(phydev->speed, phydev->duplex, phydev->supported); if (setting) {
phy_sanitize_settings() is called from phy_start_aneg() only, and only if phydev->autoneg isn't set. Therefore the removed code does nothing. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/phy/phy.c | 4 ---- 1 file changed, 4 deletions(-)